From: Kishon Vijay Abraham I <kishon@ti.com>
To: Kamil Debski <k.debski@samsung.com>,
<linux-kernel@vger.kernel.org>,
<linux-samsung-soc@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<devicetree@vger.kernel.org>
Cc: <t.figa@samsung.com>, <m.szyprowski@samsung.com>,
<gautam.vivek@samsung.com>, <matt.porter@linaro.org>
Subject: Re: [PATCH RESEND v2 1/2] phy: core: Add an exported of_phy_get function
Date: Fri, 13 Dec 2013 20:15:09 +0530 [thread overview]
Message-ID: <52AB1D75.4030207@ti.com> (raw)
In-Reply-To: <1386943380-28596-1-git-send-email-k.debski@samsung.com>
Hi,
On Friday 13 December 2013 07:32 PM, Kamil Debski wrote:
> Previously the of_phy_get function took a struct device * and
> was declared static. It was impossible to call it from
> another driver and thus it was impossible to get phy defined
> for a given node. The old function was renamed to _of_phy_get
> and was left for internal use. of_phy_get function was added
> and it was exported. The function enables to get a phy for
> a given device tree node.
>
> Signed-off-by: Kamil Debski <k.debski@samsung.com>
> ---
> It seems that my git send-email is playing up and sent the previous emails
> without from. This is a resend. Sorry for any confusion.
> ---
> drivers/phy/phy-core.c | 41 ++++++++++++++++++++++++++++++++---------
> include/linux/phy/phy.h | 1 +
> 2 files changed, 33 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
> index 03cf8fb..f0dbd42 100644
> --- a/drivers/phy/phy-core.c
> +++ b/drivers/phy/phy-core.c
> @@ -240,8 +240,8 @@ out:
> EXPORT_SYMBOL_GPL(phy_power_off);
>
> /**
> - * of_phy_get() - lookup and obtain a reference to a phy by phandle
> - * @dev: device that requests this phy
> + * _of_phy_get() - lookup and obtain a reference to a phy by phandle
> + * @np: device_node for which to get the phy
> * @index: the index of the phy
> *
> * Returns the phy associated with the given phandle value,
> @@ -250,20 +250,17 @@ EXPORT_SYMBOL_GPL(phy_power_off);
> * not yet loaded. This function uses of_xlate call back function provided
> * while registering the phy_provider to find the phy instance.
> */
> -static struct phy *of_phy_get(struct device *dev, int index)
> +static struct phy *_of_phy_get(struct device_node *np, int index)
> {
> int ret;
> struct phy_provider *phy_provider;
> struct phy *phy = NULL;
> struct of_phandle_args args;
>
> - ret = of_parse_phandle_with_args(dev->of_node, "phys", "#phy-cells",
> + ret = of_parse_phandle_with_args(np, "phys", "#phy-cells",
> index, &args);
> - if (ret) {
> - dev_dbg(dev, "failed to get phy in %s node\n",
> - dev->of_node->full_name);
> + if (ret)
> return ERR_PTR(-ENODEV);
> - }
>
> mutex_lock(&phy_provider_mutex);
> phy_provider = of_phy_provider_lookup(args.np);
> @@ -283,6 +280,32 @@ err0:
> }
>
> /**
> + * of_phy_get() - lookup and obtain a reference to a phy using a device_node.
> + * @np: device_node for which to get the phy
> + * @index: the index of the phy
Would be better if the user can get the PHY by string instead of index.
> + *
> + * Returns the phy driver, after getting a refcount to it; or
> + * -ENODEV if there is no such phy. The caller is responsible for
> + * calling phy_put() to release that count.
> + */
> +struct phy *of_phy_get(struct device_node *np, int index)
> +{
> + struct phy *phy = NULL;
> +
> + phy = _of_phy_get(np, index);
> + if (IS_ERR(phy))
dev_err here?
Thanks
Kishon
next prev parent reply other threads:[~2013-12-13 14:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 14:02 [PATCH RESEND v2 1/2] phy: core: Add an exported of_phy_get function Kamil Debski
2013-12-13 14:03 ` [PATCH v2 2/2] phy: core: Add devm_of_phy_get to phy-core Kamil Debski
2013-12-13 14:45 ` Kishon Vijay Abraham I [this message]
2013-12-13 15:26 ` [PATCH RESEND v2 1/2] phy: core: Add an exported of_phy_get function Kamil Debski
2013-12-16 9:00 ` Kishon Vijay Abraham I
2013-12-16 12:55 ` Kamil Debski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AB1D75.4030207@ti.com \
--to=kishon@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=gautam.vivek@samsung.com \
--cc=k.debski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=matt.porter@linaro.org \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).