From: John Fastabend <john.fastabend@gmail.com>
To: clbchenlibo.chen@huawei.com
Cc: David Miller <davem@davemloft.net>,
edumazet@google.com, jasowang@redhat.com, horms@verge.net.au,
serge.hallyn@ubuntu.com, netdev@vger.kernel.org,
cgroups@vger.kernel.org, containers@lists.linux-foundation.org,
kaber@trash.net, xemul@openvz.org, ebiederm@xmission.com,
linux-kernel@vger.kernel.org, jhs@mojatatu.com,
lizefan@huawei.com
Subject: Re: [RFC PATCH net-next 1/4] net: introduce backup_classid to struct skbuff
Date: Thu, 02 Jan 2014 22:21:38 -0800 [thread overview]
Message-ID: <52C656F2.8060803@gmail.com> (raw)
In-Reply-To: <20140103.003404.1439874071277993396.davem@davemloft.net>
On 01/02/2014 09:34 PM, David Miller wrote:
> From: Libo Chen <clbchenlibo.chen@huawei.com>
> Date: Fri, 3 Jan 2014 11:11:04 +0800
>
>>
>> introduce backup_classid to struct skbuff,
>> we can use it to backup sk_classid when net_ns switch.
>>
>> Signed-off-by: Libo Chen <clbchenlibo.chen@huawei.com>
>
> Sorry, no new sk_buff members unless there is absolutely not other
> possible implementation.
>
> sk_buff is too big as-is.
To get what you want fix the dev_forward_skb() call. But its
not clear to me why you would expect the sock info to be propagated
like this. It seems like an incorrect assumption or a misunderstanding
somewhere. If the virtual link was a physical link you wouldn't expect
to know anything about the senders socket.
Thanks,
John
--
John Fastabend Intel Corporation
next prev parent reply other threads:[~2014-01-03 6:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 3:11 [RFC PATCH net-next 1/4] net: introduce backup_classid to struct skbuff Libo Chen
2014-01-03 5:34 ` David Miller
2014-01-03 6:21 ` John Fastabend [this message]
2014-01-06 8:16 ` Libo Chen
2014-01-07 12:54 ` Libo Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C656F2.8060803@gmail.com \
--to=john.fastabend@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=clbchenlibo.chen@huawei.com \
--cc=containers@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=horms@verge.net.au \
--cc=jasowang@redhat.com \
--cc=jhs@mojatatu.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=serge.hallyn@ubuntu.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).