From: Tomasz Figa <t.figa@samsung.com>
To: Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
linux-crypto@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, vzapolskiy@gmail.com,
herbert@gondor.apana.org.au, naveenkrishna.ch@gmail.com,
cpgs@samsung.com, tomasz.figa@gmail.com,
Kukjin Kim <kgene.kim@samsung.com>
Subject: Re: [PATCH 5/8 v4] clk: samsung: exynos5250/5420: Add gate clock for SSS module
Date: Fri, 24 Jan 2014 16:26:38 +0100 [thread overview]
Message-ID: <52E2862E.9020402@samsung.com> (raw)
In-Reply-To: <1389777366-15147-1-git-send-email-ch.naveen@samsung.com>
Hi Naveen,
Exynos5250 specific part looks good, but I have a little doubt in case
of Exynos5420.
On 15.01.2014 10:16, Naveen Krishna Chatradhi wrote:
> This patch adds gating clock for SSS(Security SubSystem)
> module on Exynos5250/5420.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> TO: <linux-samsung-soc@vger.kernel.org>
> TO: Tomasz Figa <t.figa@samsung.com>
> CC: Kukjin Kim <kgene.kim@samsung.com>
> CC: <linux-crypto@vger.kernel.org>
> ---
> Changes since v3:
> 1. Rebased on to https://git.kernel.org/pub/scm/linux/kernel/git/tfiga/samsung-clk.git
> 2. Added new ID for SSS clock on Exynos5250, with Documentation and
> 3. Added gate clocks definitions for SSS on Exynos5420 and Exynos5250
[snip]
> --- a/drivers/clk/samsung/clk-exynos5420.c
> +++ b/drivers/clk/samsung/clk-exynos5420.c
> @@ -26,6 +26,7 @@
> #define DIV_CPU1 0x504
> #define GATE_BUS_CPU 0x700
> #define GATE_SCLK_CPU 0x800
> +#define GATE_BUS_G2D 0x8700
> #define CPLL_LOCK 0x10020
> #define DPLL_LOCK 0x10030
> #define EPLL_LOCK 0x10040
> @@ -702,6 +703,9 @@ static struct samsung_gate_clock exynos5420_gate_clks[] __initdata = {
> 0),
> GATE(CLK_SMMU_MIXER, "smmu_mixer", "aclk200_disp1", GATE_IP_DISP1, 9, 0,
> 0),
> +
> + /* SSS */
> + GATE(CLK_SSS, "sss", "aclk266_g2d", GATE_BUS_G2D, 2, 0, 0),
Isn't there a combined gate for all SSS clocks in one of GATE_IP_*
registers?
Best regards,
Tomasz
next prev parent reply other threads:[~2014-01-24 15:26 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 11:51 [PATCH 0/5] crypto:s5p-sss: Add DT and Exynos5 support Naveen Krishna Ch
2014-01-07 11:51 ` [PATCH 1/5] crypto:s5p-sss: Use platform_get_irq() instead of _byname() Naveen Krishna Ch
2014-01-08 0:14 ` Tomasz Figa
2014-01-09 4:58 ` [PATCH 1/6 v2] " Naveen Krishna Chatradhi
2014-01-10 11:41 ` [PATCH 1/8 v3] " Naveen Krishna Chatradhi
2014-01-10 15:15 ` Tomasz Figa
2014-01-15 9:14 ` [PATCH 1/8 v4] " Naveen Krishna Chatradhi
2014-01-23 10:19 ` Naveen Krishna Ch
2014-01-29 9:19 ` [PATCH 1/9 v5] " Naveen Krishna Chatradhi
2014-02-07 5:21 ` [PATCH 1/9 v6] " Naveen Krishna Chatradhi
2014-01-07 11:51 ` [PATCH 2/5] crypto:s5p-sss: Add device tree and Exynos5 support Naveen Krishna Ch
2014-01-08 0:25 ` Tomasz Figa
2014-01-09 4:59 ` [PATCH 2/6 v2] crypto:s5p-sss: Add device tree support Naveen Krishna Chatradhi
2014-01-09 14:14 ` Tomasz Figa
2014-01-10 6:07 ` Naveen Krishna Ch
2014-01-10 6:20 ` Sachin Kamat
2014-01-10 13:44 ` Tomasz Figa
2014-01-10 11:42 ` [PATCH 2/8 v3] " Naveen Krishna Chatradhi
2014-01-15 9:14 ` [PATCH 2/8 v4] " Naveen Krishna Chatradhi
2014-01-23 10:20 ` Naveen Krishna Ch
2014-01-23 10:28 ` Sylwester Nawrocki
2014-01-23 17:41 ` Mark Rutland
2014-01-23 17:47 ` Sylwester Nawrocki
2014-01-23 17:59 ` Mark Rutland
2014-01-29 9:20 ` [PATCH 2/9 v5] " Naveen Krishna Chatradhi
2014-02-06 14:36 ` Tomasz Figa
2014-02-07 5:21 ` [PATCH 2/9 v6] " Naveen Krishna Chatradhi
2014-01-07 11:51 ` [PATCH 3/5] crypto:s5p-sss: Add support for SSS module on Exynos5 Naveen Krishna Ch
2014-01-08 0:29 ` Tomasz Figa
2014-01-09 4:59 ` [PATCH 3/6 v2] crypto:s5p-sss: Add support for SSS module on Exynos Naveen Krishna Chatradhi
2014-01-09 9:32 ` Sachin Kamat
2014-01-15 9:15 ` [PATCH 3/8 v4] " Naveen Krishna Chatradhi
2014-01-24 14:09 ` Tomasz Figa
2014-01-29 9:21 ` [PATCH 3/9 v5] " Naveen Krishna Chatradhi
2014-02-06 14:39 ` Tomasz Figa
2014-01-10 11:42 ` [PATCH 3/8 v3] " Naveen Krishna Chatradhi
2014-01-10 15:44 ` Tomasz Figa
2014-01-13 21:06 ` Vladimir Zapolskiy
2014-01-14 6:16 ` Naveen Krishna Ch
2014-01-07 11:51 ` [PATCH 4/5] crypto:s5p-sss: Exynos5 SoCs too can select SSS driver Naveen Krishna Ch
2014-01-08 0:30 ` Tomasz Figa
2014-01-09 4:27 ` Naveen Krishna Ch
2014-01-09 4:59 ` [PATCH 4/6 v2] crypto:s5p-sss: Kconfig: Let Exynos SoCs " Naveen Krishna Chatradhi
2014-01-09 9:29 ` Sachin Kamat
2014-01-15 9:15 ` [PATCH 4/8 v4] " Naveen Krishna Chatradhi
2014-01-29 9:22 ` [PATCH 4/9 v5] " Naveen Krishna Chatradhi
2014-02-06 14:41 ` Tomasz Figa
2014-01-10 11:43 ` [PATCH 4/8 v3] " Naveen Krishna Chatradhi
2014-01-10 15:47 ` Tomasz Figa
2014-02-07 5:23 ` [PATCH 4/9 v6] " Naveen Krishna Chatradhi
2014-01-07 11:51 ` [PATCH 5/5] ARM: exynos5420: add dt node for sss module Naveen Krishna Ch
2014-01-08 0:32 ` Tomasz Figa
2014-01-09 4:26 ` Naveen Krishna Ch
2014-01-09 5:00 ` [PATCH 5/6 v2] ARM: dts: " Naveen Krishna Chatradhi
2014-01-10 11:44 ` [PATCH 6/8 v3] ARM: dts: exynos5250/5420: " Naveen Krishna Chatradhi
2014-01-10 16:00 ` Tomasz Figa
2014-01-10 11:43 ` [PATCH 5/8 v3] clk:exynos-5250: Add gate clock for SSS module Naveen Krishna Chatradhi
2014-01-10 15:58 ` Tomasz Figa
2014-01-15 9:05 ` Naveen Krishna Ch
2014-01-15 9:16 ` [PATCH 5/8 v4] clk: samsung: exynos5250/5420: " Naveen Krishna Chatradhi
2014-01-23 10:20 ` Naveen Krishna Ch
2014-01-24 15:26 ` Tomasz Figa [this message]
2014-01-29 9:24 ` [PATCH 5/9 v5] clk: samsung " Naveen Krishna Chatradhi
2014-02-06 14:43 ` Tomasz Figa
2014-02-07 5:24 ` [PATCH 5/9 v6] " Naveen Krishna Chatradhi
2014-02-07 5:24 ` [PATCH 6/9 v6] ARM: dts: exynos5250/5420: add dt node for sss module Naveen Krishna Chatradhi
2014-02-13 23:28 ` Kukjin Kim
2014-02-13 23:32 ` Kukjin Kim
2014-02-14 4:13 ` Naveen Krishna Ch
2014-02-14 10:54 ` Tomasz Figa
2014-02-17 8:56 ` Naveen Krishna Ch
2014-01-10 11:41 ` [PATCH 0/8 v3] crypto:s5p-sss: Add DT and Exynos support Naveen Krishna Chatradhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E2862E.9020402@samsung.com \
--to=t.figa@samsung.com \
--cc=ch.naveen@samsung.com \
--cc=cpgs@samsung.com \
--cc=herbert@gondor.apana.org.au \
--cc=kgene.kim@samsung.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
--cc=tomasz.figa@gmail.com \
--cc=vzapolskiy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).