From: Adrian Hunter <adrian.hunter@intel.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jiri Olsa <jolsa@redhat.com>, Mike Galbraith <efault@gmx.de>,
Namhyung Kim <namhyung@gmail.com>,
Paul Mackerras <paulus@samba.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH V2 9/9] perf buildid-cache: Check relocation when checking for existing kcore
Date: Thu, 30 Jan 2014 18:35:01 +0200 [thread overview]
Message-ID: <52EA7F35.8020500@intel.com> (raw)
In-Reply-To: <20140130141821.GA30054@ghostprotocols.net>
On 30/01/2014 4:18 p.m., Arnaldo Carvalho de Melo wrote:
> Em Thu, Jan 30, 2014 at 11:34:38AM +0200, Adrian Hunter escreveu:
>> On 29/01/14 21:14, Arnaldo Carvalho de Melo wrote:
>>> Em Wed, Jan 29, 2014 at 04:14:44PM +0200, Adrian Hunter escreveu:
>>>> perf buildid-cache does not make another
>>>> copy of kcore if the buildid and modules
>>>> match an existing copy. That does not
>
>>> Humm, what is the problem? Having the ref reloc symbol we can fix things
>>> up, no? I.e. just using map->reloc the old kcore copy should be ok to
>>> use, no need to replace the kcore copy in the cache. Or am I missing
>>> something?
>
>> The current implementation works on the basis that kcore matches the
>> perf data recorded. This is just a fix for that.
>
>> I am afraid it is that way because it meets my needs.
>
>> I did not think of allowing for relocation because I need to be able
>> to walk the code. Relocation was one of the things I was trying to
>> avoid.
>
>> For me making a copy of kcore is far superior because it can be made
>> to have the jump labels mostly the right way around too. e.g. run a
>> dummy perf record while making the copy.
>
> Yes, it is superior, no question about it, I'm just trying to figure out
> how this fits into the build-id cache thing, i.e. it should have files
> keyed by its build-id, that are inserted, but not replaced, since it
> expects its contents to be constant.
>
> So you have a need to get the matching kcore at the time you did the
> record, because we're dealing with self modifying code, the kernel (soon
> if not already, userspace as well)...
>
> So at least we need to make this abundantly clear to users, that what is
> in the build-id cache may be the latest snapshot of some DSO that had a
> build-id at, well, build time.
>
> We need to add support for looking up in the binary where are places
> that are modifiable and then mark those in the UI using some visual cue.
>
> Till then, at least a paragraph in the documentation stating what
> happens is needed, I'll look into it.
>
> And then right now this is just for kcore, that is clearly marked as
> such in the build-id cache, IIRC it is in a separate directory, etc,
> right?
Yes, perf buidid-cache creates a directory in the cache of the form:
[kernel.kcore]/<build-id>/<YYYYmmddHHMMSShh>
which contains 3 files: kcore, kallsyms and modules.
next prev parent reply other threads:[~2014-01-30 16:38 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-29 14:14 [PATCH V2 0/9] perf tools: kaslr fixes Adrian Hunter
2014-01-29 14:14 ` [PATCH V2 1/9] perf tools: Fix symbol annotation for relocated kernel Adrian Hunter
2014-01-29 18:57 ` Arnaldo Carvalho de Melo
2014-01-30 7:20 ` Adrian Hunter
2014-01-30 8:59 ` Ingo Molnar
2014-01-30 9:21 ` Adrian Hunter
2014-01-30 9:20 ` Ingo Molnar
2014-01-30 18:08 ` Arnaldo Carvalho de Melo
2014-01-30 18:12 ` Arnaldo Carvalho de Melo
2014-01-30 18:15 ` Arnaldo Carvalho de Melo
2014-01-30 20:10 ` Arnaldo Carvalho de Melo
2014-02-02 8:55 ` [tip:perf/urgent] perf symbols: " tip-bot for Adrian Hunter
2014-01-29 14:14 ` [PATCH V2 2/9] perf tools: Add kallsyms__get_function_start() Adrian Hunter
2014-02-02 8:55 ` [tip:perf/urgent] " tip-bot for Adrian Hunter
2014-01-29 14:14 ` [PATCH V2 3/9] perf tools: Add machine__get_kallsyms_filename() Adrian Hunter
2014-02-02 8:55 ` [tip:perf/urgent] perf machine: " tip-bot for Adrian Hunter
2014-01-29 14:14 ` [PATCH V2 4/9] perf tools: Set up ref_reloc_sym in machine__create_kernel_maps() Adrian Hunter
2014-02-02 8:55 ` [tip:perf/urgent] perf machine: " tip-bot for Adrian Hunter
2014-01-29 14:14 ` [PATCH V2 5/9] perf record: Get ref_reloc_sym from kernel map Adrian Hunter
2014-02-02 8:55 ` [tip:perf/urgent] " tip-bot for Adrian Hunter
2014-01-29 14:14 ` [PATCH V2 6/9] perf tools: Prevent the use of kcore if the kernel has moved Adrian Hunter
2014-02-02 8:56 ` [tip:perf/urgent] perf symbols: " tip-bot for Adrian Hunter
2014-01-29 14:14 ` [PATCH V2 7/9] perf tools: Test does not need to set up ref_reloc_sym Adrian Hunter
2014-02-02 8:56 ` [tip:perf/urgent] perf tests: No " tip-bot for Adrian Hunter
2014-01-29 14:14 ` [PATCH V2 8/9] perf tools: Adjust kallsyms for relocated kernel Adrian Hunter
2014-01-29 19:08 ` Arnaldo Carvalho de Melo
2014-01-30 8:10 ` Adrian Hunter
2014-01-31 18:21 ` Arnaldo Carvalho de Melo
2014-02-02 8:56 ` [tip:perf/urgent] " tip-bot for Adrian Hunter
2014-01-29 14:14 ` [PATCH V2 9/9] perf buildid-cache: Check relocation when checking for existing kcore Adrian Hunter
2014-01-29 19:14 ` Arnaldo Carvalho de Melo
2014-01-30 9:34 ` Adrian Hunter
2014-01-30 14:18 ` Arnaldo Carvalho de Melo
2014-01-30 16:35 ` Adrian Hunter [this message]
2014-02-02 8:56 ` [tip:perf/urgent] " tip-bot for Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EA7F35.8020500@intel.com \
--to=adrian.hunter@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).