From: "Kamble, Nitin A" <nitin.a.kamble@intel.com>
To: David Rientjes <rientjes@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irq: fix a Kconfig dependency
Date: Fri, 31 Jan 2014 09:44:50 -0800 [thread overview]
Message-ID: <52EBE112.5010203@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1401310223460.7183@chino.kir.corp.google.com>
On 1/31/2014 2:27 AM, David Rientjes wrote:
> On Thu, 30 Jan 2014, nitin.a.kamble@intel.com wrote:
>
>> From: Nitin A Kamble <nitin.a.kamble@intel.com>
>>
>> The generic_chip.c uses interfaces from irq_domain.c which is controlled by
>> the IRQ_DOMAIN config option.
>>
>> Add a select statement in the Kconfig to reflect this requirement.
>>
>> Without this fix, the generic_chip.c compilation fails like this:
>>
>> linux/kernel/irq/generic-chip.c:400:11:
>> error: 'irq_domain_xlate_onetwocell' undeclared here (not in a function)
>>
> You're not specifying which config option you have enabled that selects
> CONFIG_GENERIC_IRQ_CHIP and does not select CONFIG_IRQ_DOMAIN, but it does
> look like there is a dependency here.
It is enabled by GPIO_PCH as seen here:
config GPIO_PCH
tristate "Intel EG20T PCH/LAPIS Semiconductor
IOH(ML7223/ML7831) GPIO"
depends on PCI && X86
select GENERIC_IRQ_CHIP
help
This driver is for PCH(Platform controller Hub) GPIO of Intel
Topcliff
which is an IOH(Input/Output Hub) for x86 embedded processor.
This driver can access PCH GPIO device.
>
> So, if this dependency is reasonable, it begs the question of why we have
> CONFIG_GENERIC_IRQ_CHIP at all and shouldn't just make generic-chip.c
> depend on CONFIG_IRQ_DOMAIN.
Looking at the code there are cases where IRQ_DOMAIN functionality is used
without using the GENERIC_IRQ_CHIP. So making generic-chip.c depend
on CONFIG_IRQ_DOMAIN in the makefile will reduce the flexibility of using
these config options separately.
Nitin
next prev parent reply other threads:[~2014-01-31 17:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 0:50 [PATCH] a Kconfig fix nitin.a.kamble
2014-01-31 0:50 ` [PATCH] irq: fix a Kconfig dependency nitin.a.kamble
2014-01-31 10:27 ` David Rientjes
2014-01-31 17:44 ` Kamble, Nitin A [this message]
2014-01-31 20:45 ` David Rientjes
2014-02-04 17:31 ` Kamble, Nitin A
2014-02-04 18:55 ` Thomas Gleixner
2014-02-05 9:22 ` [tip:irq/urgent] genirq: Generic irq chip requires IRQ_DOMAIN tip-bot for Nitin A Kamble
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EBE112.5010203@intel.com \
--to=nitin.a.kamble@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).