From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Lyude Paul <lyude@redhat.com>, cgel.zte@gmail.com, robdclark@gmail.com
Cc: sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch,
airlied@redhat.com, laurent.pinchart@ideasonboard.com,
chi.minghao@zte.com.cn, treding@nvidia.com,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] drm/msm: remove unneeded variable
Date: Fri, 3 Sep 2021 21:31:11 +0300 [thread overview]
Message-ID: <52a6c92d-fe59-cdb8-23de-6fcda6ca2c68@linaro.org> (raw)
In-Reply-To: <2d6784e3327cab7bfdc88ca1ef7c9c4c9cca113a.camel@redhat.com>
On 02/09/2021 21:40, Lyude Paul wrote:
> Reviewed-by: Lyude Paul <lyude@redhat.com>
>
> Do you need me to push this?
We'd pick this up through the msm tree.
>
> On Tue, 2021-08-31 at 04:51 -0700, cgel.zte@gmail.com wrote:
>> From: Chi Minghao <chi.minghao@zte.com.cn>
>>
>> Fix the following coccicheck REVIEW:
>> ./drivers/gpu/drm/msm/edp/edp_ctrl.c:1245:5-8 Unneeded variable
>>
>> Reported-by: Zeal Robot <zealci@zte.com.cn>
>> Signed-off-by: Chi Minghao <chi.minghao@zte.com.cn>
>> ---
>> drivers/gpu/drm/msm/edp/edp_ctrl.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/msm/edp/edp_ctrl.c
>> b/drivers/gpu/drm/msm/edp/edp_ctrl.c
>> index 4fb397ee7c84..3610e26e62fa 100644
>> --- a/drivers/gpu/drm/msm/edp/edp_ctrl.c
>> +++ b/drivers/gpu/drm/msm/edp/edp_ctrl.c
>> @@ -1242,8 +1242,6 @@ bool msm_edp_ctrl_panel_connected(struct edp_ctrl
>> *ctrl)
>> int msm_edp_ctrl_get_panel_info(struct edp_ctrl *ctrl,
>> struct drm_connector *connector, struct edid **edid)
>> {
>> - int ret = 0;
>> -
>> mutex_lock(&ctrl->dev_mutex);
>>
>> if (ctrl->edid) {
>> @@ -1278,7 +1276,7 @@ int msm_edp_ctrl_get_panel_info(struct edp_ctrl *ctrl,
>> }
>> unlock_ret:
>> mutex_unlock(&ctrl->dev_mutex);
>> - return ret;
>> + return 0;
>> }
>>
>> int msm_edp_ctrl_timing_cfg(struct edp_ctrl *ctrl,
>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2021-09-03 18:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 11:51 [PATCH] drm/msm: remove unneeded variable cgel.zte
2021-09-02 18:40 ` Lyude Paul
2021-09-03 18:31 ` Dmitry Baryshkov [this message]
2021-09-03 18:40 ` Lyude Paul
2021-09-03 18:51 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52a6c92d-fe59-cdb8-23de-6fcda6ca2c68@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=treding@nvidia.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).