From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752877AbdKFMgL (ORCPT <rfc822;w@1wt.eu>);
        Mon, 6 Nov 2017 07:36:11 -0500
Received: from aibo.runbox.com ([91.220.196.211]:57770 "EHLO aibo.runbox.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752135AbdKFMgJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 6 Nov 2017 07:36:09 -0500
Subject: Re: [PATCH net-next 4/5] net: dsa: lan9303: Remove unnecessary
 parentheses
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
        Joe Perches <joe@perches.com>, andrew@lunn.ch, f.fainelli@gmail.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20171103105553.16859-1-privat@egil-hjelmeland.no>
 <20171103105553.16859-5-privat@egil-hjelmeland.no>
 <1509718281.15520.11.camel@perches.com>
 <32ae5cf5-ed19-106c-2625-b53074e00282@egil-hjelmeland.no>
 <878tfnct0u.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
From: Egil Hjelmeland <privat@egil-hjelmeland.no>
Message-ID: <52b70a27-7966-7dac-147c-6046befcd3c1@egil-hjelmeland.no>
Date: Mon, 6 Nov 2017 13:35:41 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <878tfnct0u.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03. nov. 2017 15:54, Vivien Didelot wrote:
> Hi Egil,
> 
> Egil Hjelmeland <privat@egil-hjelmeland.no> writes:
> 
> If you send a v2, you may want to address the other parenthesis
> alignment issues found when running ./scripts/checkpatch -f on the
> lan9303* files.
> 

There is just one remaining alignment issue. Removing that would
require introducing an extra variable just for that purpose. I
don't think that makes the code more readable. So I will not do it.
If anybody else want to do it, fine, I will just watch in silence.

> Applying this gives you a few more: https://patchwork.kernel.org/patch/10014913/
> 
> (you can also add my Reviewed-by tag on patches you didn't touch.)
> 
> 
> Thanks,
> 
>          Vivien
> 

Egil