From: Peter Rosin <peda@axentia.se>
To: Tudor.Ambarus@microchip.com, regressions@leemhuis.info,
Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com
Cc: du@axentia.se, Patrice.Vilchez@microchip.com,
Cristian.Birsan@microchip.com, Ludovic.Desroches@microchip.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org,
saravanak@google.com, dmaengine@vger.kernel.org
Subject: Re: Regression: memory corruption on Atmel SAMA5D31
Date: Fri, 29 Jul 2022 22:09:35 +0200 [thread overview]
Message-ID: <52c3b37f-dde2-9dde-df92-8ae114fa43fc@axentia.se> (raw)
In-Reply-To: <0d3beabb-5786-14a9-2918-5fc76b38034e@microchip.com>
2022-07-28 at 10:39, Tudor.Ambarus@microchip.com wrote:
> On 7/28/22 10:45, Tudor.Ambarus@microchip.com wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> On 7/13/22 19:01, Tudor.Ambarus@microchip.com wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>
>>> Hi, Peter,
>>>
>>> Thanks for the patience. I was still out of office last week,
>>> but now I have some news.
>>>
>>> On 6/27/22 19:53, Tudor.Ambarus@microchip.com wrote:
>>>> I think these are the last less invasive
>>>> changes that I try, I'll have to rewrite the logic anyway.
>>>
>>> I've chopped the driver to use virt-dma (check [1]). It's not clean, but
>>> it works and one can see how the logic is changed. Unfortunately the mem
>>> corruption is still present on high loads. Maybe it's a coherency problem.
>>> I need more time on it. Will get back to you.
>>>
>>> Cheers,
>>> ta
>>>
>>> [1] To github.com:ambarus/linux-0day.git
>>> a7351e6f4c12..1557e0df0fd0 at-hdmac-virt-dma -> at-hdmac-virt-dma
>>
>> Hi, Peter,
>>
>> Does this [1] one line patch solve the mem corruption on your side?
>> Even if yes, there are still bugs in at-hdmac that can be squashed by
>> using virt-dma. I'd like to follow up with patches that integrate
>> virt-dma logic in at-hdmac.
>>
>> Cheers,
>> ta
>>
>> [1] https://lore.kernel.org/linux-mtd/20220728074014.145406-1-tudor.ambarus@microchip.com/T/#u
>
> Hi, Peter,
>
> Looks like I've already caught an oops in at-hdmac driver when not using virt-dma,
> see below. Would you please test with all the patches from [2] instead of just
> using the patch from [1]? I've run stress tests over night by using [2] and
> everything went fine on my side.
>
> Cheers,
> ta
>
> [2] To github.com:ambarus/linux-0day.git
> * [new branch] at-hdmac-virt-dma-2nd-iteration -> at-hdmac-virt-dma-2nd-iteration
Hi Tudor,
This last one feels very promising! It's been running for a few hours without
incidents, so even if it isn't fixed it's several magnitudes better.
I'll leave it running for the night. Fingers crossed...
Cheers,
Peter
next prev parent reply other threads:[~2022-07-29 20:09 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 0:29 Regression: memory corruption on Atmel SAMA5D31 Peter Rosin
2022-03-03 3:02 ` Saravana Kannan
2022-03-03 9:17 ` Peter Rosin
2022-03-04 3:55 ` Saravana Kannan
2022-03-04 6:57 ` Peter Rosin
2022-03-04 10:57 ` Peter Rosin
2022-03-04 11:12 ` Tudor.Ambarus
2022-03-04 12:38 ` Peter Rosin
2022-03-04 16:48 ` Tudor.Ambarus
2022-03-07 9:45 ` Tudor.Ambarus
2022-03-07 11:32 ` Peter Rosin
2022-03-07 20:32 ` Peter Rosin
2022-03-08 7:55 ` Nicolas Ferre
2022-03-09 8:30 ` Peter Rosin
[not found] ` <6d9561a4-39e4-3dbe-5fe2-c6f88ee2a4c6@axentia.se>
[not found] ` <ed24a281-1790-8e24-5f5a-25b66527044b@microchip.com>
[not found] ` <d563c7ba-6431-2639-9f2a-2e2c6788e625@axentia.se>
[not found] ` <e5a715c5-ad9f-6fd4-071e-084ab950603e@microchip.com>
2022-03-10 9:58 ` Peter Rosin
2022-03-10 10:40 ` Peter Rosin
2022-04-09 13:02 ` Thorsten Leemhuis
2022-04-11 6:21 ` Tudor.Ambarus
2022-05-17 14:50 ` Peter Rosin
2022-05-18 6:21 ` Tudor.Ambarus
2022-05-18 7:51 ` Peter Rosin
2022-06-20 7:04 ` Thorsten Leemhuis
2022-06-20 8:43 ` Tudor.Ambarus
2022-06-20 14:22 ` Tudor.Ambarus
2022-06-21 7:00 ` Peter Rosin
2022-06-21 10:46 ` Peter Rosin
2022-06-27 12:26 ` Tudor.Ambarus
2022-06-27 16:53 ` Tudor.Ambarus
2022-06-30 5:20 ` Peter Rosin
2022-06-30 9:23 ` Tudor.Ambarus
2022-06-30 10:20 ` Tudor.Ambarus
2022-07-13 16:01 ` Tudor.Ambarus
2022-07-28 7:45 ` Tudor.Ambarus
2022-07-28 8:39 ` Tudor.Ambarus
2022-07-29 20:09 ` Peter Rosin [this message]
2022-07-30 11:37 ` Peter Rosin
2022-07-31 3:44 ` Tudor.Ambarus
2022-03-04 20:06 ` Saravana Kannan
2022-03-04 8:00 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52c3b37f-dde2-9dde-df92-8ae114fa43fc@axentia.se \
--to=peda@axentia.se \
--cc=Cristian.Birsan@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=Patrice.Vilchez@microchip.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=dmaengine@vger.kernel.org \
--cc=du@axentia.se \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=regressions@leemhuis.info \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).