Re: [tip:smp/hotplug 5/6] arch/x86/xen/enlighten.c:1522:2: error: implicit declaration of function 'xen_pvh_early_cpu_init'

From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: kbuild test robot <fengguang.wu@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
	tipbuild@zytor.com, jgross@suse.com,
	David Vrabel <david.vrabel@citrix.com>
Subject: Re: [tip:smp/hotplug 5/6] arch/x86/xen/enlighten.c:1522:2: error: implicit declaration of function 'xen_pvh_early_cpu_init'
Date: Thu, 28 Jul 2016 22:03:54 -0400	[thread overview]
Message-ID: <52d4970f-c308-ab58-deca-cc5e4a1198b5@oracle.com> (raw)
In-Reply-To: <201607290042.Cg7WolYT%fengguang.wu@intel.com>

On 07/28/2016 12:14 PM, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git smp/hotplug
> head:   c713c8cb2055f5f3b32ee4315be589177a2658cc
> commit: 854e9fa5a56a9771fad4701a427e4844d2cbade1 [5/6] xen/x86: Define stubs for xen_smp_intr_init/xen_smp_intr_free
> config: x86_64-randconfig-x011-201630 (attached as .config)
> compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
>         git checkout 854e9fa5a56a9771fad4701a427e4844d2cbade1
>         # save the attached .config to linux build tree
>         make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
>    arch/x86/xen/enlighten.c: In function 'xen_pvh_early_guest_init':
>>> arch/x86/xen/enlighten.c:1522:2: error: implicit declaration of function 'xen_pvh_early_cpu_init' [-Werror=implicit-function-declaration]
>      xen_pvh_early_cpu_init(0, false);
>      ^~~~~~~~~~~~~~~~~~~~~~

Thomas,

So I clearly missed the PVH case and I see that the patches were 
reverted from the branch. Do you want me to take them through Xen tree 
so you won't have to deal with breakage?

If yes I will assume your ACK for the second patch
http://marc.info/?i=1458221613-21563-3-git-send-email-boris.ostrovsky%40oracle.com

Sorry about that.

-boris

>    cc1: some warnings being treated as errors
>
> vim +/xen_pvh_early_cpu_init +1522 arch/x86/xen/enlighten.c
>
> d285d683 Mukesh Rathor   2013-12-13  1516
> c9f6e997 Roger Pau Monne 2014-01-20  1517  	if (!xen_feature(XENFEAT_hvm_callback_vector))
> c9f6e997 Roger Pau Monne 2014-01-20  1518  		return;
> c9f6e997 Roger Pau Monne 2014-01-20  1519
> d285d683 Mukesh Rathor   2013-12-13  1520  	xen_have_vector_callback = 1;
> a2ef5dc2 Mukesh Rathor   2014-09-10  1521
> a2ef5dc2 Mukesh Rathor   2014-09-10 @1522  	xen_pvh_early_cpu_init(0, false);
> c9f6e997 Roger Pau Monne 2014-01-20  1523  	xen_pvh_set_cr_flags(0);
> d285d683 Mukesh Rathor   2013-12-13  1524
> d285d683 Mukesh Rathor   2013-12-13  1525  #ifdef CONFIG_X86_32
>
> :::::: The code at line 1522 was first introduced by commit
> :::::: a2ef5dc2c7cbedbeb4c847039845afaea5e63745 x86/xen: Set EFER.NX and EFER.SCE in PVH guests
>
> :::::: TO: Mukesh Rathor <mukesh.rathor@oracle.com>
> :::::: CC: David Vrabel <david.vrabel@citrix.com>
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>