linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roland Dreier <roland@topspin.com>
To: linux-kernel@vger.kernel.org
Subject: Correct way to release get_user_pages()?
Date: Thu, 27 Jan 2005 19:02:28 -0800	[thread overview]
Message-ID: <52pszqw917.fsf@topspin.com> (raw)

Reading through the tree, I see that some callers of get_user_pages()
release the pages that they got via put_page(), and some callers use
page_cache_release().  Of course <linux/pagemap.h> has

	#define page_cache_release(page)      put_page(page)

so this is really not much of a difference, but I'd like to know which
is considered better style.  Any opinions?

Thanks,
  Roland


             reply	other threads:[~2005-01-28  3:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-28  3:02 Roland Dreier [this message]
2005-01-28 17:48 ` Correct way to release get_user_pages()? Timur Tabi
2005-01-30 10:10   ` Andrew Morton
2005-01-31 15:51     ` Timur Tabi
2005-01-31 21:01       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52pszqw917.fsf@topspin.com \
    --to=roland@topspin.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).