From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44CEEC2D0E4 for ; Fri, 18 Dec 2020 21:22:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0939223B88 for ; Fri, 18 Dec 2020 21:22:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726494AbgLRVWC convert rfc822-to-8bit (ORCPT ); Fri, 18 Dec 2020 16:22:02 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:34021 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725778AbgLRVWC (ORCPT ); Fri, 18 Dec 2020 16:22:02 -0500 Received: from marcel-macbook.holtmann.net (p4fefcdf9.dip0.t-ipconnect.de [79.239.205.249]) by mail.holtmann.org (Postfix) with ESMTPSA id 6F417CED31; Fri, 18 Dec 2020 22:28:36 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.40.0.2.32\)) Subject: Re: [PATCH] Bluetooth: btqcomsmd: Fix a resource leak in error handling paths in the probe function From: Marcel Holtmann In-Reply-To: <20201212094658.83861-1-christophe.jaillet@wanadoo.fr> Date: Fri, 18 Dec 2020 22:21:19 +0100 Cc: agross@kernel.org, bjorn.andersson@linaro.org, Johan Hedberg , MSM , linux-bluetooth , LKML , kernel-janitors@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <53063008-8797-4395-B9D1-9D56D2D0D54C@holtmann.org> References: <20201212094658.83861-1-christophe.jaillet@wanadoo.fr> To: Christophe JAILLET X-Mailer: Apple Mail (2.3654.40.0.2.32) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christophe, > Some resource should be released in the error handling path of the probe > function, as already done in the remove function. > > The remove function was fixed in commit 5052de8deff5 ("soc: qcom: smd: > Transition client drivers from smd to rpmsg") > > Fixes: 1511cc750c3d ("Bluetooth: Introduce Qualcomm WCNSS SMD based HCI driver") > Signed-off-by: Christophe JAILLET > --- > drivers/bluetooth/btqcomsmd.c | 27 +++++++++++++++++++-------- > 1 file changed, 19 insertions(+), 8 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel