From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751635AbaBZBeE (ORCPT ); Tue, 25 Feb 2014 20:34:04 -0500 Received: from terminus.zytor.com ([198.137.202.10]:34447 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750800AbaBZBeC (ORCPT ); Tue, 25 Feb 2014 20:34:02 -0500 Message-ID: <530D4445.8060304@zytor.com> Date: Tue, 25 Feb 2014 17:32:53 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: behanw@converseincode.com, mmarek@suse.cz, tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, sparse@chrisli.org CC: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sparse@vger.kernel.org, torvalds@linux-foundation.org, dwmw2@infradead.org, pageexec@freemail.hu, =?UTF-8?B?SmFuLVNpbW9uIE3Dtmxs?= =?UTF-8?B?ZXI=?= , Mark Charlebois Subject: Re: [PATCH 5/5] x86 kbuild: LLVMLinux: More cc-options added for clang References: <1393376923-21892-1-git-send-email-behanw@converseincode.com> <1393376923-21892-6-git-send-email-behanw@converseincode.com> In-Reply-To: <1393376923-21892-6-git-send-email-behanw@converseincode.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/25/2014 05:08 PM, behanw@converseincode.com wrote: > > +# enforce no-sse for clang > +ifneq ($(COMPILER),clang) > + KBUILD_CFLAGS += $(call cc-option,-mno-sse) > + KBUILD_CFLAGS += $(call cc-option,-mpreferred-stack-boundary=3) > +endif > + I'm *very* confused. You're doing ifneq here but you're talking about it as if you are *adding* them for Clang, also these options are already added elsewhere (lines 57, 64, 86, 89) so why add them here? -hpa