From: Behan Webster <behanw@converseincode.com>
To: "H. Peter Anvin" <hpa@zytor.com>,
mmarek@suse.cz, tglx@linutronix.de, mingo@redhat.com,
x86@kernel.org, sparse@chrisli.org
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sparse@vger.kernel.org, torvalds@linux-foundation.org,
dwmw2@infradead.org, pageexec@freemail.hu,
"Jan-Simon Möller" <dl9pf@gmx.de>,
"Mark Charlebois" <charlebm@gmail.com>
Subject: Re: [PATCH 5/5] x86 kbuild: LLVMLinux: More cc-options added for clang
Date: Tue, 25 Feb 2014 17:44:15 -0800 [thread overview]
Message-ID: <530D46EF.6010103@converseincode.com> (raw)
In-Reply-To: <530D4445.8060304@zytor.com>
On 02/25/14 17:32, H. Peter Anvin wrote:
> On 02/25/2014 05:08 PM, behanw@converseincode.com wrote:
>>
>> +# enforce no-sse for clang
>> +ifneq ($(COMPILER),clang)
>> + KBUILD_CFLAGS += $(call cc-option,-mno-sse)
>> + KBUILD_CFLAGS += $(call cc-option,-mpreferred-stack-boundary=3)
>> +endif
>> +
> I'm *very* confused. You're doing ifneq here but you're talking about
> it as if you are *adding* them for Clang, also these options are already
> added elsewhere (lines 57, 64, 86, 89) so why add them here?
Because when David Woodhouse's recent .code16 changes made it upstream
(which invalidated most of our original patch) it seems I didn't remove
this properly from our patch as well. :)
Thanks David for your patches. Thanks Peter for your sharp eyes!
Another example of why reviewing code on the mailing list works so well.
I will fix and resend.
Behan
--
Behan Webster
behanw@converseincode.com
next prev parent reply other threads:[~2014-02-26 1:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 1:08 [PATCH 0/5] kbuild: LLVMLinux: Initial updates to kbuild to enable the kernel to be compiled with clang/LLVM behanw
2014-02-26 1:08 ` [PATCH 1/5] kbuild: LLVMLinux: Add Kbuild support for building kernel with Clang behanw
2014-03-09 21:58 ` Sam Ravnborg
2014-03-11 6:58 ` Behan Webster
2014-03-11 21:26 ` [PATCH 1/5 v2] " behanw
2014-02-26 1:08 ` [PATCH 2/5] kbuild: LLVMLinux: Adapt warnings for compilation with clang behanw
2014-02-26 1:17 ` Dave Jones
2014-02-26 1:31 ` Behan Webster
2014-02-26 1:34 ` H. Peter Anvin
2014-02-26 2:38 ` Behan Webster
2014-03-06 17:59 ` [PATCH 2/5 v2] " behanw
2014-02-26 1:08 ` [PATCH 3/5] kbuild: LLVMLinux: Fix LINUX_COMPILER definition script " behanw
2014-02-26 1:08 ` [PATCH 4/5] LLVMLinux: Add support for clang to compiler.h and new compiler-clang.h behanw
2014-02-26 1:08 ` [PATCH 5/5] x86 kbuild: LLVMLinux: More cc-options added for clang behanw
2014-02-26 1:32 ` H. Peter Anvin
2014-02-26 1:44 ` Behan Webster [this message]
2014-03-06 18:03 ` [PATCH 5/5 v2] " behanw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530D46EF.6010103@converseincode.com \
--to=behanw@converseincode.com \
--cc=charlebm@gmail.com \
--cc=dl9pf@gmx.de \
--cc=dwmw2@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mmarek@suse.cz \
--cc=pageexec@freemail.hu \
--cc=sparse@chrisli.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).