linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Hurley <peter@hurleysoftware.com>
To: Kay Sievers <kay@vrfy.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.cz>, LKML <linux-kernel@vger.kernel.org>,
	Ray Strode <halfline@gmail.com>,
	David Herrmann <dh.herrmann@gmail.com>,
	Lennart Poettering <lennart@poettering.net>,
	Werner Fink <werner@suse.de>
Subject: Re: [PATCH] tty: Add sysfs symlink for console name->tty device
Date: Thu, 27 Feb 2014 09:00:18 -0500	[thread overview]
Message-ID: <530F44F2.6050802@hurleysoftware.com> (raw)
In-Reply-To: <CAPXgP12ATVb_L2sCaNWN4tozN1Cu0efSWb-VTXdqui4SFkzc=w@mail.gmail.com>

On 02/27/2014 08:36 AM, Kay Sievers wrote:
> On Thu, Feb 27, 2014 at 2:31 PM, Peter Hurley <peter@hurleysoftware.com> wrote:
>> On 02/27/2014 06:13 AM, Kay Sievers wrote:
>>>
>>> On Wed, Feb 26, 2014 at 3:40 PM, Peter Hurley <peter@hurleysoftware.com>
>>> wrote:
>>>>
>>>> Enable a user-space process to discover the underlying tty device
>>>> for a console, if one exists, and when the tty device is later
>>>> created or destroyed.
>>>>
>>>> Add sysfs symlinks for registered consoles to their respective
>>>> devices in [sys/class,sys/devices/virtual]/tty/console.
>>>> Scan consoles at tty device (un)registration to handle deferred
>>>> console<->device (un)binding.
>>>
>>> What tool is supposed to read that? I can't think of anything
>>> interested in this, as soon as we have fixed the "active" console
>>> output.
>
>> With all due respect, that "fix" is a ridiculous hack,
>
> No, it is not. It's fine to handle tty0 special, as it is special.

I wasn't just referring to the plymouth workaround.

>> being done
>> for self-serving expedience.
>
> I don't see the problem.
>
>> It already caused one user-space breakage
>> which you did not expect.
>
> That is normal way to do things, only people who don't do things don't
> break things. And broken things get fixed, and the "active" file is still
> fixable, and that is what we should do.

But what's the plan when more user-space breakage is uncovered after that
change has been in 10 kernel releases?

Then everyone will point to how much user-space breakage reverting it
will cause.

> We don't need to invent new things because we did not get things right
> with the first try.
>
>> This sysfs interface is superior in every way.
>
> But nothing uses it now, and probably never will, so I don't see the
> need for it at this moment.

Let's just avoid the mess right up-front.

Regards,
Peter Hurley

  reply	other threads:[~2014-02-27 14:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-26 14:40 [PATCH] tty: Add sysfs symlink for console name->tty device Peter Hurley
2014-02-27 11:13 ` Kay Sievers
2014-02-27 13:31   ` Peter Hurley
2014-02-27 13:36     ` Kay Sievers
2014-02-27 14:00       ` Peter Hurley [this message]
2014-03-01  0:35 ` Greg Kroah-Hartman
2014-03-01  0:40   ` Peter Hurley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530F44F2.6050802@hurleysoftware.com \
    --to=peter@hurleysoftware.com \
    --cc=dh.herrmann@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=halfline@gmail.com \
    --cc=jslaby@suse.cz \
    --cc=kay@vrfy.org \
    --cc=lennart@poettering.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=werner@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).