From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>
Cc: Xiubo Li <Li.Xiubo@freescale.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCHv2 2/3] ASoC: io: New signature for snd_soc_codec_set_cache_io()
Date: Sat, 01 Mar 2014 14:05:34 +0100 [thread overview]
Message-ID: <5311DB1E.30008@metafoo.de> (raw)
In-Reply-To: <20140301043458.GR29849@sirena.org.uk>
On 03/01/2014 05:34 AM, Mark Brown wrote:
> On Fri, Feb 28, 2014 at 05:04:26PM +0800, Xiubo Li wrote:
>> Now that all users have been converted to regmap and the config.reg_bits
>> and config.val_bits can be setted by each user through regmap core API.
>> So these two params are redundant here.
>
> Actually, I think the way to fix the issue with CODECs doing I/O in
> probe is to provide a way for drivers to specify a regmap when
> registering the CODEC (rather than during probe) and then move the
> initialisation of the regmap before the probe function is called. That
> would make set_cache_io() go away entirely.
Yep, that's actually my preference as well.
next prev parent reply other threads:[~2014-03-01 13:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 9:04 [PATCHv2 0/3] Simplify the CODEC ASoC probe code Xiubo Li
2014-02-28 9:04 ` [PATCHv2 1/3] ASoC: codec: Simplify " Xiubo Li
2014-02-28 14:41 ` [alsa-devel] " Lars-Peter Clausen
2014-03-03 1:58 ` Li.Xiubo
2014-03-01 4:28 ` Mark Brown
2014-03-03 3:01 ` Li.Xiubo
2014-03-03 4:50 ` Mark Brown
2014-02-28 9:04 ` [PATCHv2 2/3] ASoC: io: New signature for snd_soc_codec_set_cache_io() Xiubo Li
2014-03-01 4:29 ` Mark Brown
2014-03-01 4:34 ` Mark Brown
2014-03-01 13:05 ` Lars-Peter Clausen [this message]
2014-02-28 9:04 ` [PATCHv2 3/3] ASoC: core: Fix check before setting default I/O up try regmap Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5311DB1E.30008@metafoo.de \
--to=lars@metafoo.de \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).