From: James Hogan <james.hogan@imgtec.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
<grant.likely@linaro.org>, <linus.walleij@linaro.org>,
Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] irq: Changed the return type of irq_chip.irq_startup() from unsigned int to int
Date: Tue, 4 Mar 2014 11:14:32 +0000 [thread overview]
Message-ID: <5315B598.5020207@imgtec.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1403041134410.18573@ionos.tec.linutronix.de>
On 04/03/14 10:57, Thomas Gleixner wrote:
> The reason is the usage of commata instead of semicolons. You can work
> around that with cocci, but that gets ugly ....
>
> Thanks,
>
> tglx
>
> --- a/drivers/gpio/gpio-tz1090.c
> +++ b/drivers/gpio/gpio-tz1090.c
> @@ -488,26 +488,26 @@ static int tz1090_gpio_bank_probe(struct tz1090_gpio_bank_info *info)
> gc->chip_types[0].handler = handle_level_irq;
> gc->chip_types[0].regs.ack = REG_GPIO_IRQ_STS;
> gc->chip_types[0].regs.mask = REG_GPIO_IRQ_EN;
> - gc->chip_types[0].chip.irq_startup = gpio_startup_irq,
> - gc->chip_types[0].chip.irq_ack = irq_gc_ack_clr_bit,
> - gc->chip_types[0].chip.irq_mask = irq_gc_mask_clr_bit,
> - gc->chip_types[0].chip.irq_unmask = irq_gc_mask_set_bit,
> - gc->chip_types[0].chip.irq_set_type = gpio_set_irq_type,
> - gc->chip_types[0].chip.irq_set_wake = gpio_set_irq_wake,
> - gc->chip_types[0].chip.flags = IRQCHIP_MASK_ON_SUSPEND,
> + gc->chip_types[0].chip.irq_startup = gpio_startup_irq;
> + gc->chip_types[0].chip.irq_ack = irq_gc_ack_clr_bit;
> + gc->chip_types[0].chip.irq_mask = irq_gc_mask_clr_bit;
> + gc->chip_types[0].chip.irq_unmask = irq_gc_mask_set_bit;
> + gc->chip_types[0].chip.irq_set_type = gpio_set_irq_type;
> + gc->chip_types[0].chip.irq_set_wake = gpio_set_irq_wake;
> + gc->chip_types[0].chip.flags = IRQCHIP_MASK_ON_SUSPEND;
>
> /* edge chip type */
> gc->chip_types[1].type = IRQ_TYPE_EDGE_BOTH;
> gc->chip_types[1].handler = handle_edge_irq;
> gc->chip_types[1].regs.ack = REG_GPIO_IRQ_STS;
> gc->chip_types[1].regs.mask = REG_GPIO_IRQ_EN;
> - gc->chip_types[1].chip.irq_startup = gpio_startup_irq,
> - gc->chip_types[1].chip.irq_ack = irq_gc_ack_clr_bit,
> - gc->chip_types[1].chip.irq_mask = irq_gc_mask_clr_bit,
> - gc->chip_types[1].chip.irq_unmask = irq_gc_mask_set_bit,
> - gc->chip_types[1].chip.irq_set_type = gpio_set_irq_type,
> - gc->chip_types[1].chip.irq_set_wake = gpio_set_irq_wake,
> - gc->chip_types[1].chip.flags = IRQCHIP_MASK_ON_SUSPEND,
> + gc->chip_types[1].chip.irq_startup = gpio_startup_irq;
> + gc->chip_types[1].chip.irq_ack = irq_gc_ack_clr_bit;
> + gc->chip_types[1].chip.irq_mask = irq_gc_mask_clr_bit;
> + gc->chip_types[1].chip.irq_unmask = irq_gc_mask_set_bit;
> + gc->chip_types[1].chip.irq_set_type = gpio_set_irq_type;
> + gc->chip_types[1].chip.irq_set_wake = gpio_set_irq_wake;
> + gc->chip_types[1].chip.flags = IRQCHIP_MASK_ON_SUSPEND;
>
> /* Setup chained handler for this GPIO bank */
> irq_set_handler_data(bank->irq, bank);
>
Whoops, that was a subtle mistake from when I converted it from static
irqchips to using the generic irqchip stuff. Thanks for the patch, I'll
add a commit message and resubmit.
Cheers
James
next prev parent reply other threads:[~2014-03-04 11:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 16:28 [PATCH] irq: Consider a negative return value of irq_startup() as an error Jean-Jacques Hiblot
2014-02-26 22:15 ` Thomas Gleixner
2014-02-27 16:03 ` Jean-Jacques Hiblot
2014-02-27 17:21 ` [PATCH] irq: Changed the return type of irq_chip.irq_startup() from unsigned int to int Jean-Jacques Hiblot
2014-02-28 22:52 ` James Hogan
2014-03-01 15:31 ` Thomas Gleixner
2014-03-01 16:01 ` Russell King - ARM Linux
2014-03-03 8:55 ` Jean-Jacques Hiblot
2014-03-04 10:57 ` Thomas Gleixner
2014-03-04 11:14 ` James Hogan [this message]
2014-03-03 9:22 ` [PATCH v2] " Jean-Jacques Hiblot
2014-03-07 2:49 ` [PATCH] irq: Consider a negative return value of irq_startup() as an error Linus Walleij
2014-03-08 9:15 ` Thomas Gleixner
2014-03-12 14:49 ` Linus Walleij
2014-03-12 15:10 ` Thomas Gleixner
2014-03-14 9:28 ` Linus Walleij
2014-03-12 15:06 ` [tip:irq/core] genirq: Provide irq_request/ release_resources chip callbacks tip-bot for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5315B598.5020207@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=grant.likely@linaro.org \
--cc=jjhiblot@traphandler.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).