From: Tomasz Figa <t.figa@samsung.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com
Cc: rafael.j.wysocki@intel.com, nm@ti.com, b.zolnierkie@samsaung.com,
pawel.moll@arm.com, mark.rutland@arm.com, swarren@wwwdotorg.org,
ijc+devicetree@hellion.org.uk, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCHv2 0/8] devfreq: exynos4: Support dt and use common ppmu driver
Date: Fri, 14 Mar 2014 18:58:06 +0100 [thread overview]
Message-ID: <5323432E.5060005@samsung.com> (raw)
In-Reply-To: <1394698649-20996-1-git-send-email-cw00.choi@samsung.com>
Hi Chanwoo,
On 13.03.2014 09:17, Chanwoo Choi wrote:
> This patchset support devicetree and use common ppmu driver instead of
> individual code of exynos4_bus.c to remove duplicate code. Also this patchset
> get the resources for busfreq from dt data by using DT helper function.
> - PPMU register address
> - PPMU clock
> - Regulator for INT/MIF block
>
> This patchset use SET_SYSTEM_SLEEP_PM_OPS macro intead of legacy method.
> To remove power-leakage in suspend state, before entering suspend state,
> disable ppmu clocks.
>
> Changes from v1:
> - Add exynos4_bus.txt documentation for devicetree guide
> - Fix probe failure if CONFIG_PM_OPP is disabled
> - Fix typo and resource leak(regulator/clock/memory) when happening probe failure
> - Add additionally comment for PPMU usage instead of previous PPC
> - Split separate patch to remove ambiguous of patch
>
> Chanwoo Choi (8):
> devfreq: exynos4: Support devicetree to get device id of Exynos4 SoC
> devfreq: exynos4: Use common ppmu driver and get ppmu address from dt data
> devfreq: exynos4: Add ppmu's clock control and code clean about regulator control
> devfreq: exynos4: Fix bug of resource leak and code clean on probe()
> devfreq: exynos4: Use SET_SYSTEM_SLEEP_PM_OPS macro
> devfreq: exynos4: Fix power-leakage of clock on suspend state
> devfreq: exynos4: Add CONFIG_PM_OPP dependency to fix probe fail
> devfreq: exynos4: Add busfreq driver for exynos4210/exynos4x12
>
> .../devicetree/bindings/devfreq/exynos4_bus.txt | 49 +++
> drivers/devfreq/Kconfig | 1 +
> drivers/devfreq/exynos/Makefile | 2 +-
> drivers/devfreq/exynos/exynos4_bus.c | 415 ++++++++++++++-------
> 4 files changed, 341 insertions(+), 126 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/devfreq/exynos4_bus.txt
>
I have reviewed this series and there are several comments that I'd like
to ask you to address. Please see my replies to particular patches.
However, this driver, even after applying your series, is still far from
a state that would allow it to be enabled. The most important issue is
direct access to CMU registers, based on static mapping, which is not
allowed on multiplatform kernels and multiplatform-awareness for drivers
is currently a must.
To allow this driver to be enabled, it needs to be converted to use
common clock framework functions to configure all clocks, e.g.
clk_set_rate(), clk_set_parent(), etc., without accessing CMU registers
directly.
Of course as long as the driver is effectively unusable, to keep
development, we can proceed with refactoring it step-by-step and your
series would be basically the first step, after addressing the review
comments.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-03-14 17:58 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 8:17 [PATCHv2 0/8] devfreq: exynos4: Support dt and use common ppmu driver Chanwoo Choi
2014-03-13 8:17 ` [PATCHv2 1/8] devfreq: exynos4: Support devicetree to get device id of Exynos4 SoC Chanwoo Choi
2014-03-13 8:17 ` [PATCHv2 2/8] devfreq: exynos4: Use common ppmu driver and get ppmu address from dt data Chanwoo Choi
2014-03-13 8:17 ` [PATCHv2 3/8] devfreq: exynos4: Add ppmu's clock control and code clean about regulator control Chanwoo Choi
2014-03-14 17:42 ` Tomasz Figa
2014-03-17 2:51 ` Chanwoo Choi
2014-03-17 5:35 ` Chanwoo Choi
2014-03-17 5:59 ` Chanwoo Choi
2014-03-18 11:13 ` Tomasz Figa
2014-03-19 2:44 ` Chanwoo Choi
2014-03-13 8:17 ` [PATCHv2 4/8] devfreq: exynos4: Fix bug of resource leak and code clean on probe() Chanwoo Choi
2014-03-14 17:49 ` Tomasz Figa
2014-03-17 5:05 ` Chanwoo Choi
2014-03-18 12:18 ` Tomasz Figa
2014-03-19 2:46 ` Chanwoo Choi
2014-03-13 8:17 ` [PATCHv2 5/8] devfreq: exynos4: Use SET_SYSTEM_SLEEP_PM_OPS macro Chanwoo Choi
2014-03-13 8:17 ` [PATCHv2 6/8] devfreq: exynos4: Fix power-leakage of clock on suspend state Chanwoo Choi
2014-03-14 17:52 ` Tomasz Figa
2014-03-17 2:58 ` Chanwoo Choi
2014-03-13 8:17 ` [PATCHv2 7/8] devfreq: exynos4: Add CONFIG_PM_OPP dependency to fix probe fail Chanwoo Choi
2014-03-13 8:17 ` [PATCHv2 8/8] devfreq: exynos4: Add busfreq driver for exynos4210/exynos4x12 Chanwoo Choi
2014-03-13 16:50 ` Bartlomiej Zolnierkiewicz
2014-03-13 17:53 ` Mark Rutland
2014-03-14 7:14 ` Chanwoo Choi
2014-03-14 10:35 ` Mark Rutland
2014-03-14 10:56 ` Chanwoo Choi
2014-03-14 17:35 ` Tomasz Figa
2014-03-15 11:36 ` Kyungmin Park
2014-03-15 12:41 ` Tomasz Figa
2014-03-17 5:19 ` Chanwoo Choi
2014-03-18 15:46 ` Tomasz Figa
2014-03-19 9:47 ` Chanwoo Choi
2014-03-19 10:23 ` Tomasz Figa
2014-03-13 16:43 ` [PATCHv2 0/8] devfreq: exynos4: Support dt and use common ppmu driver Bartlomiej Zolnierkiewicz
2014-03-14 3:14 ` Chanwoo Choi
2014-03-14 10:47 ` Bartlomiej Zolnierkiewicz
2014-03-17 1:56 ` Chanwoo Choi
2014-03-14 17:58 ` Tomasz Figa [this message]
2014-03-17 1:58 ` Chanwoo Choi
2014-03-18 15:47 ` Tomasz Figa
2014-07-09 13:06 ` Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5323432E.5060005@samsung.com \
--to=t.figa@samsung.com \
--cc=b.zolnierkie@samsaung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kyungmin.park@samsung.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=nm@ti.com \
--cc=pawel.moll@arm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).