From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACDA6C43215 for ; Tue, 19 Nov 2019 10:57:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F914222DD for ; Tue, 19 Nov 2019 10:57:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=chronox.de header.i=@chronox.de header.b="PQ3F5gHz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727573AbfKSK5W (ORCPT ); Tue, 19 Nov 2019 05:57:22 -0500 Received: from mo4-p02-ob.smtp.rzone.de ([85.215.255.80]:30729 "EHLO mo4-p02-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726170AbfKSK5W (ORCPT ); Tue, 19 Nov 2019 05:57:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1574161039; s=strato-dkim-0002; d=chronox.de; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=WnvWEcD1OrisdQgGt5N9I3ouD0nZvk5Ggwkbt0h9+NM=; b=PQ3F5gHzfWRsdXUMqQBIHETC07qc1jHFDZUSMFCejtlKP7vFn9iMan8Pisuo/mPFhc OhR8tshwaBoyr6673hfVB1NwaPDXA10atBcnSTbTpXqLhndus48Cq2zhAH0HQhE7i+O+ nVJViTOYC2RFi2Xgkz0OUno2cuMMBROiowZ9ndUDWN/3Jc6lse/AAxEoPafQUkyO2xH4 qisGi9xvAyjXspSeDAY3vSG4pyerXDq/ISl+eFwlZoIw+wITIgCJMDPU1kGd92sUgAuV QVVgjq8aIqVP2ie9tpiZifKBinWPQj3D+y9iyZsf00rXk1gz2bSEEQN8gcXilYjGHOXt qkDw== X-RZG-AUTH: ":P2ERcEykfu11Y98lp/T7+hdri+uKZK8TKWEqNyiHySGSa9k9zT8DNpa83PTIPmLqL6mXsiNby0r49Q+bn6Gzw6e9E9jMEY/jj9Sk" X-RZG-CLASS-ID: mo00 Received: from tauon.chronox.de by smtp.strato.de (RZmta 44.29.0 AUTH) with ESMTPSA id N09a57vAJAtTetb (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Tue, 19 Nov 2019 11:55:29 +0100 (CET) From: Stephan Mueller To: Andy Lutomirski Cc: Arnd Bergmann , Greg Kroah-Hartman , Linux Crypto Mailing List , LKML , Linux API , "Eric W. Biederman" , "Alexander E. Patrakov" , "Ahmed S. Darwish" , "Theodore Y. Ts'o" , Willy Tarreau , Matthew Garrett , Vito Caputo , Andreas Dilger , Jan Kara , Ray Strode , William Jon McCann , zhangjs , Florian Weimer , Lennart Poettering , Nicolai Stange , "Peter, Matthias" , Marcelo Henrique Cerri , Roman Drahtmueller , Neil Horman Subject: Re: [PATCH v25 03/12] LRNG - /proc interface Date: Tue, 19 Nov 2019 11:55:23 +0100 Message-ID: <5323691.yyFvDVlHDV@tauon.chronox.de> In-Reply-To: References: <2476454.l8LQlgn7Hv@positron.chronox.de> <3043322.Kq9igzfA0K@positron.chronox.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 19. November 2019, 11:06:02 CET schrieb Andy Lutomirski: Hi Andy, > On Sun, Nov 17, 2019 at 4:16 AM Stephan M=C3=BCller = wrote: > > Am Samstag, 16. November 2019, 17:39:40 CET schrieb Andy Lutomirski: > >=20 > > Hi Andy, > >=20 > > > > On Nov 16, 2019, at 1:40 AM, Stephan M=C3=BCller > > > > wrote: > > > >=20 > > > > =EF=BB=BFThe LRNG /proc interface provides the same files as the le= gacy > > > > /dev/random. These files behave identically. Yet, all files are > > > > documented at [1]. > > >=20 > > > Why? > >=20 > > I am not sure here: are you referring to the documentation? Or the one > > additional file? > >=20 > > If it is the documentation, do you want me to add it to the patch > > description? I initially did not add it as these files were present and > > seemingly known what they provide. But I would add that documentation to > > the patch description if this is desired. >=20 > Sorry, I should have been a lot more explicit. Why do you want to add > a new interface to read the RNG? What's wrong with the old one? There is nothing wrong at all. I actually want to be 100% API and ABI=20 compliant with the existing random.c. Thus, the list of the sysctls are=20 identical to the existing random.c with the same behavior (hence I skipped = the=20 documentation of these files). Yet, the wiring up of the interfaces to internal data structures and handle= rs=20 is different than for the existing random.c. Also, the reason why I created a separate lrng_proc.c (and lrng_interface.c= )=20 is to allow a possible merger of this similar code with the existing random= =2Ec.=20 The only question that needs to be solved is to find a common way to invoke= =20 the random.c internal logic and the LRNG internal logic with these interfac= es. >=20 > I think your patch description should explain the purpose of the patch. Ok, I can surely add a description for each file to the patch description. Ciao Stephan