From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8654C63697 for ; Fri, 13 Nov 2020 16:58:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0AFF21D1A for ; Fri, 13 Nov 2020 16:58:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726288AbgKMQ6D (ORCPT ); Fri, 13 Nov 2020 11:58:03 -0500 Received: from mailout01.rmx.de ([94.199.90.91]:53925 "EHLO mailout01.rmx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726136AbgKMQ6B (ORCPT ); Fri, 13 Nov 2020 11:58:01 -0500 Received: from kdin02.retarus.com (kdin02.dmz1.retloc [172.19.17.49]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout01.rmx.de (Postfix) with ESMTPS id 4CXl5d0DPVz2SVY5; Fri, 13 Nov 2020 17:57:57 +0100 (CET) Received: from mta.arri.de (unknown [217.111.95.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by kdin02.retarus.com (Postfix) with ESMTPS id 4CXl5D2TCwz2TTLW; Fri, 13 Nov 2020 17:57:36 +0100 (CET) Received: from n95hx1g2.localnet (192.168.54.14) by mta.arri.de (192.168.100.104) with Microsoft SMTP Server (TLS) id 14.3.487.0; Fri, 13 Nov 2020 17:56:34 +0100 From: Christian Eggers To: Vladimir Oltean CC: Jakub Kicinski , Andrew Lunn , "Richard Cochran" , Rob Herring , "Vivien Didelot" , "David S . Miller" , Kurt Kanzenbach , George McCollister , Marek Vasut , Helmut Grohne , Paul Barker , "Codrin Ciubotariu" , Tristram Ha , Woojung Huh , Microchip Linux Driver Support , , , Subject: Re: [PATCH net-next v2 03/11] net: dsa: microchip: split ksz_common.h Date: Fri, 13 Nov 2020 17:56:34 +0100 Message-ID: <5328227.AyQhSCNoNJ@n95hx1g2> Organization: Arnold & Richter Cine Technik GmbH & Co. Betriebs KG In-Reply-To: <20201112230254.v6bzsud3jlcmsjm2@skbuf> References: <20201112153537.22383-1-ceggers@arri.de> <20201112153537.22383-4-ceggers@arri.de> <20201112230254.v6bzsud3jlcmsjm2@skbuf> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Originating-IP: [192.168.54.14] X-RMX-ID: 20201113-175738-4CXl5D2TCwz2TTLW-0@kdin02 X-RMX-SOURCE: 217.111.95.66 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, 13 November 2020, 00:02:54 CET, Vladimir Oltean wrote: > On Thu, Nov 12, 2020 at 04:35:29PM +0100, Christian Eggers wrote: > > Parts of ksz_common.h (struct ksz_device) will be required in > > net/dsa/tag_ksz.c soon. So move the relevant parts into a new header > > file. > > > > Signed-off-by: Christian Eggers > > --- > > I had to skip ahead to see what you're going to use struct ksz_port and > struct ksz_device for. It looks like you need: > > struct ksz_port::tstamp_rx_latency_ns > struct ksz_device::ptp_clock_lock > struct ksz_device::ptp_clock_time > > Not more. > > Why don't you go the other way around, i.e. exporting some functions > from your driver, and calling them from the tagger? Good question... But as for as I can see, there are a single tagger and multiple device drivers (currently KSZ8795 and KSZ9477). Moving the KSZ9477 specific stuff, which is required by the tagger, into the KSZ9477 device driver, would make the tagger dependent on the driver(s). Currently, no tagger seems to have this direction of dependency (at least I cannot find this in net/dsa/Kconfig). If I shall change this anyway, I would use #ifdefs within the tag_ksz driver in order to avoid unnecessary dependencies to the KSZ9477 driver for the case only KSZ8795 is selected. > You could even move > the entire ksz9477_tstamp_to_clock() into the driver as-is, as far as I > can see.