From: Pankaj Dubey <pankaj.dubey@samsung.com>
To: monstr@monstr.eu
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
kgene.kim@samsung.com, linux@arm.linux.org.uk,
chow.kim@samsung.com
Subject: Re: [PATCH 02/10] ARM: EXYNOS: Correct file path in comment message
Date: Thu, 03 Apr 2014 10:40:40 +0900 [thread overview]
Message-ID: <533CBC18.8050106@samsung.com> (raw)
In-Reply-To: <533BFC31.1080203@monstr.eu>
Hi Michal,
On 04/02/2014 09:01 PM, Michal Simek wrote:
> On 04/02/2014 09:50 AM, Pankaj Dubey wrote:
>> This patch corrects file path mentioned in file comment message.
>>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>> ---
>> arch/arm/mach-exynos/platsmp.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c
>> index 03e5e9f..d8d1555 100644
>> --- a/arch/arm/mach-exynos/platsmp.c
>> +++ b/arch/arm/mach-exynos/platsmp.c
>> @@ -1,4 +1,4 @@
>> -/* linux/arch/arm/mach-exynos4/platsmp.c
>> +/* linux/arch/arm/mach-exynos/platsmp.c
>> *
>> * Copyright (c) 2010-2011 Samsung Electronics Co., Ltd.
>> * http://www.samsung.com
>>
> Shouldn't you just remove it entirely?
> I had the same file names in the whole microblaze tree
> and some months/years later this was just broken everywhere.
> That's why it is just easier to remove it entirely.
Thanks for review and suggestion.
Removing of file name makes more sense to me also.
Will take care of this in some other files also under "mach-exynos"
in next version of patch.
>
> Thanks,
> Michal
>
>
--
Best Regards,
Pankaj Dubey
next prev parent reply other threads:[~2014-04-03 1:23 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 7:50 [PATCH 0/7] ARM: Exynos: PMU cleanup and refactoring for using DT Pankaj Dubey
2014-04-02 7:50 ` [PATCH 01/10] ARM: EXYNOS: Cleanup "mach-exynos/common.h" file Pankaj Dubey
2014-04-08 15:59 ` Tomasz Figa
2014-04-10 4:35 ` Pankaj Dubey
2014-04-02 7:50 ` [PATCH 02/10] ARM: EXYNOS: Correct file path in comment message Pankaj Dubey
2014-04-02 12:01 ` Michal Simek
2014-04-03 1:40 ` Pankaj Dubey [this message]
2014-04-03 2:12 ` Kukjin Kim
2014-04-02 7:50 ` [PATCH 03/10] ARM: EXYNOS: Move SYSREG definition into sys-reg specific file Pankaj Dubey
2014-04-02 11:27 ` Sylwester Nawrocki
2014-04-11 6:07 ` Pankaj Dubey
2014-04-02 7:50 ` [PATCH 04/10] ARM: EXYNOS: Remove regs-pmu.h file dependency from pm_domain Pankaj Dubey
2014-04-02 7:50 ` [PATCH 05/10] ARM: EXYNOS: Move "regs-pmu" header inclusion in common.h Pankaj Dubey
2014-04-08 16:09 ` Tomasz Figa
2014-04-10 4:58 ` Pankaj Dubey
2014-04-02 7:50 ` [PATCH 06/10] ARM: EXYNOS: Add support for mapping PMU base address via DT Pankaj Dubey
2014-04-02 11:48 ` Sylwester Nawrocki
2014-04-02 12:15 ` Michal Simek
2014-04-03 9:07 ` Sylwester Nawrocki
2014-04-05 10:58 ` Pankaj Dubey
2014-04-07 6:02 ` Michal Simek
2014-04-05 10:53 ` Pankaj Dubey
2014-04-23 13:02 ` Vikas Sajjan
2014-04-24 2:45 ` Pankaj Dubey
2014-04-02 7:50 ` [PATCH 07/10] ARM: EXYNOS: Refactored code for PMU register mapping " Pankaj Dubey
2014-04-25 12:32 ` [PATCH v2 00/10] ARM: Exynos: PMU cleanup and refactoring for using DT Pankaj Dubey
2014-04-25 12:32 ` [PATCH v2 01/10] ARM: EXYNOS: Make exynos machine_ops as static Pankaj Dubey
2014-04-25 21:05 ` Tomasz Figa
2014-04-26 4:42 ` Pankaj Dubey
2014-04-25 12:32 ` [PATCH v2 02/10] ARM: EXYNOS: Cleanup "mach-exynos/common.h" file Pankaj Dubey
2014-04-25 21:06 ` Tomasz Figa
2014-04-25 12:32 ` [PATCH v2 03/10] ARM: EXYNOS: Move SYSREG definition into sys-reg specific file Pankaj Dubey
2014-04-25 21:08 ` Tomasz Figa
2014-04-25 12:32 ` [PATCH v2 04/10] ARM: EXYNOS: Remove file path from comment section Pankaj Dubey
2014-04-25 21:14 ` Tomasz Figa
2014-04-25 12:32 ` [PATCH v2 05/10] ARM: EXYNOS: Remove regs-pmu.h header dependency from pm_domain Pankaj Dubey
2014-04-25 21:19 ` Tomasz Figa
2014-04-26 3:39 ` Pankaj Dubey
2014-04-25 12:32 ` [PATCH v2 06/10] ARM: EXYNOS: Add support for mapping PMU base address via DT Pankaj Dubey
2014-04-25 21:43 ` Tomasz Figa
2014-04-27 7:29 ` Pankaj Dubey
2014-04-25 12:32 ` [PATCH v2 07/10] ARM: EXYNOS: Remove "linux/bug.h" from pmu.c Pankaj Dubey
2014-04-25 21:44 ` Tomasz Figa
2014-04-25 12:32 ` [PATCH v2 08/10] ARM: EXYNOS: Refactored code for using PMU address via DT Pankaj Dubey
2014-04-25 22:19 ` Tomasz Figa
2014-04-26 3:32 ` Pankaj Dubey
2014-04-25 12:32 ` [PATCH v2 09/10] ARM: EXYNOS: Move "mach/map.h" inclusion from regs-pmu.h to platsmp.c Pankaj Dubey
2014-04-25 12:32 ` [PATCH v2 10/10] ARM: EXYNOS: Add device tree based initialization support for PMU Pankaj Dubey
2014-04-25 22:40 ` Tomasz Figa
2014-04-26 4:36 ` Pankaj Dubey
2014-04-25 22:43 ` [PATCH v2 00/10] ARM: Exynos: PMU cleanup and refactoring for using DT Tomasz Figa
2014-04-26 2:07 ` Pankaj Dubey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533CBC18.8050106@samsung.com \
--to=pankaj.dubey@samsung.com \
--cc=chow.kim@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=monstr@monstr.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).