From: Stephen Boyd <sboyd@codeaurora.org>
To: Alex Elder <elder@linaro.org>,
mporter@linaro.org, bcm@fixthebug.org,
devicetree@vger.kernel.org, arnd@arndb.de
Cc: bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] ARM: add SMP support for Broadcom mobile SoCs
Date: Fri, 04 Apr 2014 10:55:40 -0700 [thread overview]
Message-ID: <533EF21C.6000909@codeaurora.org> (raw)
In-Reply-To: <1396577891-2713-3-git-send-email-elder@linaro.org>
On 04/03/14 19:18, Alex Elder wrote:
> +
> +/*
> + * Secondary startup method setup routine to extract the location of
> + * the secondary boot register from a "cpu" or "cpus" device tree
> + * node. Only the first seen secondary boot register value is used;
> + * any others are ignored. The secondary boot register value must be
> + * non-zero.
> + *
> + * Returns 0 if successful or an error code otherwise.
> + */
> +static int __init of_enable_method_setup(struct device_node *node)
> +{
> + int ret;
> +
> + /* Ignore all but the first one specified */
> + if (secondary_boot)
> + return 0;
> +
> + ret = of_property_read_u32(node, OF_SECONDARY_BOOT, &secondary_boot);
> + if (ret)
> + pr_err("%s: missing/invalid " OF_SECONDARY_BOOT " property\n",
> + node->name);
> +
> + return ret;
> +}
I don't understand why we need this. Why can't we get the secondary boot
address from the /cpus node in the smp_prepare_cpus op. It isn't that
hard to get access to the cpus node there via of_find_node_by_path().
Then we don't need patch 1 at all. If it turns out to be common stuff,
we can always have the common function live in arm common code or maybe
even be a devicetree API.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-04-04 17:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 2:18 [PATCH 0/5] ARM: SMP: support Broadcom mobile SoCs Alex Elder
2014-04-04 2:18 ` [PATCH 1/5] ARM: introduce CPU_METHOD_OF_DECLARE_SETUP() Alex Elder
2014-04-04 2:18 ` [PATCH 2/5] ARM: add SMP support for Broadcom mobile SoCs Alex Elder
2014-04-04 2:26 ` Alex Elder
2014-04-04 15:30 ` Tim Kryger
2014-04-04 18:56 ` Alex Elder
2014-04-15 12:30 ` Alex Elder
2014-04-04 17:55 ` Stephen Boyd [this message]
2014-04-04 19:30 ` Alex Elder
2014-05-05 22:02 ` Alex Elder
2014-05-06 1:43 ` Stephen Boyd
2014-05-06 4:05 ` Alex Elder
2014-04-04 2:18 ` [PATCH 3/5] ARM: configs: enable SMP in bcm_defconfig Alex Elder
2014-04-04 10:21 ` Alex Elder
2014-04-04 2:18 ` [PATCH 4/5] ARM: dts: enable SMP support for bcm28155 Alex Elder
2014-04-04 2:18 ` [PATCH 5/5] ARM: dts: enable SMP support for bcm21664 Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533EF21C.6000909@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bcm@fixthebug.org \
--cc=devicetree@vger.kernel.org \
--cc=elder@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mporter@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).