linux-next: Fixes tag needs some work in the staging.current tree

linux-next: Fixes tag needs some work in the staging.current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Hi all,

In commit

  85ae3aeedecc ("iio: imu: st_lsm6dsx: forbid 0 sensor sensitivity")

Fixes tag

  Fixes: c8d4066c7246 ("iio: imu: st_lsm6dsx: remove invalid gain value for LSM9DS1")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: 0f7e17286b45 ("iio: imu: st_lsm6dsx: remove invalid gain value for LSM9DS1")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: Fixes tag needs some work in the staging.current tree

[Jonathan Cameron]

Hi Stephen

Sorry, I've clearly let another one of these through.

Stupid question of the day.  Don't suppose you can share how you check these?

Thanks,

Jonathan


-----Original Message-----
From: Stephen Rothwell [mailto:sfr@canb.auug.org.au] 
Sent: 10 October 2019 21:43
To: Greg KH <greg@kroah.com>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Lorenzo Bianconi <lorenzo@kernel.org>; Jonathan Cameron <jonathan.cameron@huawei.com>
Subject: linux-next: Fixes tag needs some work in the staging.current tree

Hi all,

In commit

  85ae3aeedecc ("iio: imu: st_lsm6dsx: forbid 0 sensor sensitivity")

Fixes tag

  Fixes: c8d4066c7246 ("iio: imu: st_lsm6dsx: remove invalid gain value for LSM9DS1")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: 0f7e17286b45 ("iio: imu: st_lsm6dsx: remove invalid gain value for LSM9DS1")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Fixes tag needs some work in the staging.current tree

[Greg KH]

On Fri, Oct 11, 2019 at 08:10:23AM +0000, Jonathan Cameron wrote:
> Hi Stephen
> 
> Sorry, I've clearly let another one of these through.
> 
> Stupid question of the day.  Don't suppose you can share how you check these?

There's a script, that I posted to the workflows mailing list, that
should check these, based on Stephen's script.

But it didn't seem to catch this problem, which is odd, I must have
messed something up...

greg k-h

Re: linux-next: Fixes tag needs some work in the staging.current tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 752 bytes --]

Hi Jonathan,

On Fri, 11 Oct 2019 10:29:02 +0200 Greg KH <greg@kroah.com> wrote:
>
> On Fri, Oct 11, 2019 at 08:10:23AM +0000, Jonathan Cameron wrote:
> > Hi Stephen
> > 
> > Sorry, I've clearly let another one of these through.
> > 
> > Stupid question of the day.  Don't suppose you can share how you check these?  
> 
> There's a script, that I posted to the workflows mailing list, that
> should check these, based on Stephen's script.
> 
> But it didn't seem to catch this problem, which is odd, I must have
> messed something up...

Attached is my script.  It takes a range of commits to check.  Usually
after I fetch a tree I pass it "^origin/master <old head of tree>...<new head of tree>".

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: check_fixes --]
[-- Type: application/x-shellscript, Size: 4344 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the staging.current tree

[Jonathan Cameron]

On Sun, 28 Jul 2019 15:13:55 +0200
Greg KH <greg@kroah.com> wrote:

> On Sun, Jul 28, 2019 at 11:01:47PM +1000, Stephen Rothwell wrote:
> > Hi all,
> > 
> > In commit
> > 
> >   5a304e1a4ea0 ("IIO: Ingenic JZ47xx: Set clock divider on probe")
> > 
> > Fixes tag
> > 
> >   Fixes: 1a78daea107d ("iio: adc: probe should set clock divider")
> > 
> > has these problem(s):
> > 
> >   - Subject does not match target commit subject
> >     Just use
> > 	git log -1 --format='Fixes: %h ("%s")'
> > 
> > Did you mean
> > 
> > Fixes: 1a78daea107d ("IIO: add Ingenic JZ47xx ADC driver.")  
> 
> Jonathan, I'm guessing this was your fault...
> 
> greg k-h

Indeed should have spotted that one.
Sorry about that, I'll check these more thoroughly.

Thanks for pointing it out Stephen!

Jonathan

Re: linux-next: Fixes tag needs some work in the staging.current tree

[Greg KH]

On Sun, Jul 28, 2019 at 11:01:47PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   5a304e1a4ea0 ("IIO: Ingenic JZ47xx: Set clock divider on probe")
> 
> Fixes tag
> 
>   Fixes: 1a78daea107d ("iio: adc: probe should set clock divider")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 
> Did you mean
> 
> Fixes: 1a78daea107d ("IIO: add Ingenic JZ47xx ADC driver.")

Jonathan, I'm guessing this was your fault...

greg k-h

linux-next: Fixes tag needs some work in the staging.current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Hi all,

In commit

  5a304e1a4ea0 ("IIO: Ingenic JZ47xx: Set clock divider on probe")

Fixes tag

  Fixes: 1a78daea107d ("iio: adc: probe should set clock divider")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Did you mean

Fixes: 1a78daea107d ("IIO: add Ingenic JZ47xx ADC driver.")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]