linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Cc: Stanley Chu <stanley.chu@mediatek.com>,
	Can Guo <cang@codeaurora.org>, Bean Huo <beanhuo@micron.com>,
	Asutosh Das <asutoshd@codeaurora.org>
Subject: Re: [PATCH] scsi: ufs: add missing host_lock in setup_xfer_req
Date: Thu, 1 Jul 2021 10:00:35 -0700	[thread overview]
Message-ID: <5349dca5-b8a4-d668-9370-c722da7c9ead@acm.org> (raw)
In-Reply-To: <cb928bc9-0124-f082-8b5a-584afd9f1d66@acm.org>

On 7/1/21 8:23 AM, Bart Van Assche wrote:
> On 6/30/21 5:51 PM, Jaegeuk Kim wrote:
>> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
>> index c98d540ac044..194755c9ddfe 100644
>> --- a/drivers/scsi/ufs/ufshcd.h
>> +++ b/drivers/scsi/ufs/ufshcd.h
>> @@ -1229,8 +1229,13 @@ static inline int ufshcd_vops_pwr_change_notify(struct ufs_hba *hba,
>>  static inline void ufshcd_vops_setup_xfer_req(struct ufs_hba *hba, int tag,
>>  					bool is_scsi_cmd)
>>  {
>> -	if (hba->vops && hba->vops->setup_xfer_req)
>> -		return hba->vops->setup_xfer_req(hba, tag, is_scsi_cmd);
>> +	if (hba->vops && hba->vops->setup_xfer_req) {
>> +		unsigned long flags;
>> +
>> +		spin_lock_irqsave(hba->host->host_lock, flags);
>> +		hba->vops->setup_xfer_req(hba, tag, is_scsi_cmd);
>> +		spin_unlock_irqrestore(hba->host->host_lock, flags);
>> +	}
>>  }
> 
> Since this function has only one caller, how about moving it into ufshcd.c?

(replying to my own email)

Since I just noticed that there are many other similar function
definitions in ufshcd.h, let's postpone moving these definitions until a
later time.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

  reply	other threads:[~2021-07-01 17:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-01  0:51 [PATCH] scsi: ufs: add missing host_lock in setup_xfer_req Jaegeuk Kim
2021-07-01 15:23 ` Bart Van Assche
2021-07-01 17:00   ` Bart Van Assche [this message]
2021-07-13 19:06 ` Bart Van Assche
2021-07-13 19:45   ` Bean Huo
2021-07-14 18:09     ` Bart Van Assche
2021-07-14 21:22       ` Bean Huo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5349dca5-b8a4-d668-9370-c722da7c9ead@acm.org \
    --to=bvanassche@acm.org \
    --cc=asutoshd@codeaurora.org \
    --cc=beanhuo@micron.com \
    --cc=cang@codeaurora.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=stanley.chu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).