From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Jan Moskyto Matejka <mq@suse.cz>, Randy Dunlap <rdunlap@infradead.org>
Cc: mtk.manpages@gmail.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc: fix documentation for /proc/stat, line "intr"
Date: Tue, 22 Apr 2014 20:19:23 +0200 [thread overview]
Message-ID: <5356B2AB.3020005@gmail.com> (raw)
In-Reply-To: <1398180580-8089-1-git-send-email-mq@suse.cz>
On 04/22/2014 05:29 PM, Jan Moskyto Matejka wrote:
> The sum at the beginning of line "intr" includes also unnumbered interrupts.
> It implies that the sum at the beginning isn't the sum of the remainder of the
> line, not even an estimation.
>
> Fixed the documentation to mention that.
I'm not really doubting what you claim, Jan, but it would be really
helpful if you provided some data to support the proposed change
(Kernel source references, or notes about testing you've done, or
pointers to mailing list threads, authoritative note that you are
the maintainer of some relevant kernel subsystem...). Do you have
something like that? (It's also useful for the change log.)
Thanks,
Michael
> Signed-off-by: Jan Moskyto Matejka <mq@suse.cz>
> ---
> Documentation/filesystems/proc.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/filesystems/proc.txt b/Documentation/filesystems/proc.txt
> index f00bee1..4e6f9d0 100644
> --- a/Documentation/filesystems/proc.txt
> +++ b/Documentation/filesystems/proc.txt
> @@ -1245,8 +1245,9 @@ second). The meanings of the columns are as follows, from left to right:
>
> The "intr" line gives counts of interrupts serviced since boot time, for each
> of the possible system interrupts. The first column is the total of all
> -interrupts serviced; each subsequent column is the total for that particular
> -interrupt.
> +interrupts serviced including unnumbered architecture specific interrupts;
> +each subsequent column is the total for that particular numbered interrupt.
> +Unnumbered interrupts are not shown, only summed into the total.
>
> The "ctxt" line gives the total number of context switches across all CPUs.
>
>
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
next prev parent reply other threads:[~2014-04-22 18:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 15:29 [PATCH] proc: fix documentation for /proc/stat, line "intr" Jan Moskyto Matejka
2014-04-22 18:19 ` Michael Kerrisk (man-pages) [this message]
2014-04-22 22:35 ` Randy Dunlap
2014-04-23 4:57 ` Michael Kerrisk (man-pages)
2014-04-23 5:14 ` Michael Kerrisk (man-pages)
2014-04-23 9:48 ` Jan Moskyto Matejka
2014-04-23 12:48 ` Michael Kerrisk (man-pages)
2014-04-27 0:15 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5356B2AB.3020005@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mq@suse.cz \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).