From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751792AbaDXFif (ORCPT ); Thu, 24 Apr 2014 01:38:35 -0400 Received: from mail-ee0-f43.google.com ([74.125.83.43]:52946 "EHLO mail-ee0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860AbaDXFib (ORCPT ); Thu, 24 Apr 2014 01:38:31 -0400 Message-ID: <53589E8E.1040000@gmail.com> Date: Thu, 24 Apr 2014 07:18:06 +0200 From: "Michael Kerrisk (man-pages)" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Davidlohr Bueso CC: mtk.manpages@gmail.com, Manfred Spraul , Davidlohr Bueso , Martin Schwidefsky , LKML , Andrew Morton , KAMEZAWA Hiroyuki , KOSAKI Motohiro , gthelen@google.com, aswin@hp.com, linux-mm@kvack.org Subject: Re: [PATCH 5/4] ipc,shm: minor cleanups References: <1398090397-2397-1-git-send-email-manfred@colorfullife.com> <1398221636.6345.9.camel@buesod1.americas.hpqcorp.net> <53574AA5.1060205@gmail.com> <1398230745.27667.2.camel@buesod1.americas.hpqcorp.net> In-Reply-To: <1398230745.27667.2.camel@buesod1.americas.hpqcorp.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/23/2014 07:25 AM, Davidlohr Bueso wrote: > On Wed, 2014-04-23 at 07:07 +0200, Michael Kerrisk (man-pages) wrote: >> On 04/23/2014 04:53 AM, Davidlohr Bueso wrote: >>> - Breakup long function names/args. >>> - Cleaup variable declaration. >>> - s/current->mm/mm >>> >>> Signed-off-by: Davidlohr Bueso >>> --- >>> ipc/shm.c | 40 +++++++++++++++++----------------------- >>> 1 file changed, 17 insertions(+), 23 deletions(-) >>> >>> diff --git a/ipc/shm.c b/ipc/shm.c >>> index f000696..584d02e 100644 >>> --- a/ipc/shm.c >>> +++ b/ipc/shm.c >>> @@ -480,15 +480,13 @@ static const struct vm_operations_struct shm_vm_ops = { >>> static int newseg(struct ipc_namespace *ns, struct ipc_params *params) >>> { >>> key_t key = params->key; >>> - int shmflg = params->flg; >>> + int id, error, shmflg = params->flg; >> >> It's largely a matter of taste (and I may be in a minority), and I know >> there's certainly precedent in the kernel code, but I don't much like the >> style of mixing variable declarations that have initializers, with other >> unrelated declarations (e.g., variables without initializers). What is >> the gain? One less line of text? That's (IMO) more than offset by the >> small loss of readability. > > Yes, it's taste. And yes, your in the minority, at least in many core > kernel components and ipc. Davidlohr, So, noting that the minority is less small than we thought, I'll just add this: I'd have appreciated it if your reply had been less dismissive, and you'd actually responded to my concrete point about loss of readability. Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/