From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967470AbdD0IXj (ORCPT ); Thu, 27 Apr 2017 04:23:39 -0400 Received: from mga02.intel.com ([134.134.136.20]:28365 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936969AbdD0IXF (ORCPT ); Thu, 27 Apr 2017 04:23:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,257,1488873600"; d="scan'208";a="850337945" From: Lv Zheng To: "Rafael J . Wysocki" , "Rafael J . Wysocki" , Len Brown Cc: Lv Zheng , Lv Zheng , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Dan Williams Subject: [PATCH v2 1/2] ACPICA: Tables: Fix regression introduced by a too early mechanism enabling Date: Thu, 27 Apr 2017 16:22:44 +0800 Message-Id: <5361b51c7c257b3216475018a3a5cc4f8b6b21c6.1493281247.git.lv.zheng@intel.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the Linux kernel side, acpi_get_table() clones haven't been fully balanced by acpi_put_table() invocations. In ACPICA side, due to the design change, there are also unbalanced acpi_get_table_by_index() invocations requiring special care to be cleaned up. So it is not a good timing to report acpi_get_table() counting errors for this period. The strict balanced validation count check should only be enabled after confirming that all invocations are safe and compliant to their designed purposes. Thus this patch removes the fatal error along with lthe error report to fix this issue. Reported by Dan Williams, fixed by Lv Zheng. Fixes: 174cc7187e6f ("ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel") Reported-by: Dan Williams Signed-off-by: Lv Zheng --- drivers/acpi/acpica/tbutils.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/acpica/tbutils.c b/drivers/acpi/acpica/tbutils.c index 5a968a7..8175c70 100644 --- a/drivers/acpi/acpica/tbutils.c +++ b/drivers/acpi/acpica/tbutils.c @@ -418,11 +418,13 @@ acpi_tb_get_table(struct acpi_table_desc *table_desc, table_desc->validation_count++; if (table_desc->validation_count == 0) { + table_desc->validation_count--; +#if 0 ACPI_ERROR((AE_INFO, "Table %p, Validation count is zero after increment\n", table_desc)); - table_desc->validation_count--; return_ACPI_STATUS(AE_LIMIT); +#endif } *out_table = table_desc->pointer; -- 2.7.4