From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dave.hansen@intel.com>
X-Google-Smtp-Source: AH8x225dz/rNjO8D8LSxYtM3TV+CA3VZCmVAS7oVjgbsBDKPy6VoModLkKxE5qddZUIWqgDQJdBn
ARC-Seal: i=1; a=rsa-sha256; t=1517068513; cv=none;
        d=google.com; s=arc-20160816;
        b=zZIMLiBv2x+2LTUeC8lUvKkzjQ0ZxN0omT1o1UoSGOHfx6OD5afCniapGlBYOYarr+
         Gg5+LKLCjptsez2UcBkqn9smLopCcmjeMPM8W2P8UvTESfMwX2/QGVXKXsFh/MVEpcca
         Efnk/FVd+dSbMH5JxtirYS0D8APwia6SBigY7SAFA4RIzCCG8FXxGtQZGCc5rIBQvaZ5
         dFWdNOi8QEqiz7iF9DFY2NQtogk7oL4K8kjPqhRpWRA8pVb2MA96r31lhpjxrSzHscNv
         i3ux9+7j/zSjfpy0Mp5nlygYx9YL17UsY8h5xgW1H16Co7+sE5PYCeJqKFFxK9FmblwJ
         au5g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=content-transfer-encoding:content-language:in-reply-to:mime-version
         :user-agent:date:message-id:from:cc:references:to:subject
         :arc-authentication-results;
        bh=3xkR0i5FzjgvdddwYZbvl61SuZROrRt1qGJhCTlJiEU=;
        b=0au3mBQPfWwcFvgWYWbIOiqWZagd+SpWWjqHfjFpH5/oLb2ZHdRK0hesBcbd5+/4Fu
         uanuUedOwUeSKGiMx8/AmQQebkXGI7JQeFk36V8m+R+N0GAK5eNqYmHsJo1ZygzmP8Vk
         loWCJmyNqYUnRXPAvJwqleu1M0QkSmY91pt4hAfINkOBzB2rtGhEcfQPoXbMG36VlYWe
         NRTWYkQaQKANNLHMShU3A4i9IwTkMPRIc+PqK6RQRoTc76lDZRe1N3WFJrxmK0BTpTtr
         TLeyDQsw32hQyZunzKpBJs8YeO3XeQ7kec+Hm2GfmWTDYq4JqltnxaJBZMn8RodfVno2
         zmQA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of dave.hansen@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=dave.hansen@intel.com
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of dave.hansen@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=dave.hansen@intel.com
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,422,1511856000";
   d="scan'208";a="13567421"
Subject: Re: [RFC 09/10] x86/enter: Create macros to restrict/unrestrict
 Indirect Branch Speculation
To: Konrad Rzeszutek Wilk <konrad@darnok.org>
References: <7c0b0879-3448-43e4-8380-4708fc787113@default>
 <50c5d627-8975-184b-b50f-4cc02c5816c5@intel.com>
 <1516957886.30244.161.camel@infradead.org>
 <CA+55aFxRsAh_dv6aoDNj+yqzcgzctda0ETZ_2DbjMwSZDwPLDA@mail.gmail.com>
 <20180126175901.GL26209@tassilo.jf.intel.com>
 <20180126190257.GS14668@char.us.oracle.com>
 <0089A7AA75120F4087B2E7CB6BF3E53442A9AA0A@CRSMSX104.amr.corp.intel.com>
 <20180127134239.GA25029@localhost.localdomain>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Andi Kleen <ak@linux.intel.com>,
 Linus Torvalds <torvalds@linux-foundation.org>,
 David Woodhouse <dwmw2@infradead.org>, Liran Alon <liran.alon@oracle.com>,
 Laura Abbott <labbott@redhat.com>, Andrew Lutomirski <luto@kernel.org>,
 Janakarajan Natarajan <Janakarajan.Natarajan@amd.com>,
 Borislav Petkov <bp@suse.de>, "Mallick, Asit K" <asit.k.mallick@intel.com>,
 =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
 KarimAllah Ahmed <karahmed@amazon.de>, Peter Anvin <hpa@zytor.com>,
 "Nakajima, Jun" <jun.nakajima@intel.com>, Ingo Molnar <mingo@redhat.com>,
 the arch/x86 maintainers <x86@kernel.org>, "Raj, Ashok"
 <ashok.raj@intel.com>, "Van De Ven, Arjan" <arjan.van.de.ven@intel.com>,
 Tim Chen <tim.c.chen@linux.intel.com>, Paolo Bonzini <pbonzini@redhat.com>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 Peter Zijlstra <peterz@infradead.org>, Thomas Gleixner <tglx@linutronix.de>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Masami Hiramatsu <mhiramat@kernel.org>,
 Arjan van de Ven <arjan@linux.intel.com>,
 Tom Lendacky <thomas.lendacky@amd.com>,
 "Williams, Dan J" <dan.j.williams@intel.com>, Joerg Roedel
 <joro@8bytes.org>, Andrea Arcangeli <aarcange@redhat.com>,
 KVM list <kvm@vger.kernel.org>, Boris Ostrovsky <boris.ostrovsky@oracle.com>
From: Dave Hansen <dave.hansen@intel.com>
Message-ID: <536542f0-99eb-742b-9d17-5b06e89ee383@intel.com>
Date: Sat, 27 Jan 2018 07:55:10 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20180127134239.GA25029@localhost.localdomain>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: =?utf-8?q?1590140582166248265?=
X-GMAIL-MSGID: =?utf-8?q?1590761633458160146?=
X-Mailing-List: linux-kernel@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>

On 01/27/2018 05:42 AM, Konrad Rzeszutek Wilk wrote:
> On Fri, Jan 26, 2018 at 07:11:47PM +0000, Hansen, Dave wrote:
>> The need for RSB stuffing in all the various scenarios and what the heck it actually mitigates is freakishly complicated.  I've tried to write it all down in one place: https://goo.gl/pXbvBE
> Thank you for sharing that.
> 
> One question on the third from the top (' RSB Stuff (16) After
> irq/nmi/#PF/...').
> 
> It says that :"Return from interrupt path (more than 16 deep) can empty
> RSB".
> 
> Just to clarify - you mean all the returns ('ret') that are happening after
> we call do_IRQ and the stack unwinds - but before we do an 'iret' correct?

Correct.  The RSB is not used or updated by iret.