From: Michal Simek <monstr@monstr.eu>
To: Peter Korsgaard <peter@korsgaard.com>
Cc: Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, arnd@arndb.de,
Peter Korsgaard <jacmet@sunsite.dk>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH] tty: serial: uartlite: Specify time for sending chars
Date: Tue, 06 May 2014 06:48:52 +0200 [thread overview]
Message-ID: <536869B4.3070506@monstr.eu> (raw)
In-Reply-To: <87wqe0gggo.fsf@dell.be.48ers.dk>
[-- Attachment #1: Type: text/plain, Size: 1510 bytes --]
On 05/05/2014 09:42 PM, Peter Korsgaard wrote:
>>>>>> "Michal" == Michal Simek <monstr@monstr.eu> writes:
>
> Hi,
>
> >> > diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c
> >> > index 5f90ef24d475..723a6b79cd14 100644
> >> > --- a/drivers/tty/serial/uartlite.c
> >> > +++ b/drivers/tty/serial/uartlite.c
> >> > @@ -418,14 +418,20 @@ static struct uart_ops ulite_ops = {
> >> > #ifdef CONFIG_SERIAL_UARTLITE_CONSOLE
> >> > static void ulite_console_wait_tx(struct uart_port *port)
> >> > {
> >> > - int i;
> >> > u8 val;
> >> > + unsigned long timeout;
> >>
> >> > /* Spin waiting for TX fifo to have space available */
> >> > - for (i = 0; i < 100000; i++) {
> >>
> >> It would be good to add a note about the slow jtag variant here.
>
> > What exactly you would like to see here?
> > Just that this 1s is here because of mdm uart.
>
> Something like:
>
> /*
> * Spin waiting for TX fifo to have space available.
> * When using the Microblaze Debug Module this can take up to 1s
> */
up to you. You are driver owner. :-)
I have sent v2 with this change and I have added your ACK.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
prev parent reply other threads:[~2014-05-06 4:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 14:48 [PATCH] tty: serial: uartlite: Specify time for sending chars Michal Simek
2014-05-05 15:03 ` Peter Korsgaard
2014-05-05 18:24 ` Michal Simek
2014-05-05 19:42 ` Peter Korsgaard
2014-05-06 4:48 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536869B4.3070506@monstr.eu \
--to=monstr@monstr.eu \
--cc=arnd@arndb.de \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=jacmet@sunsite.dk \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=peter@korsgaard.com \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).