From: Rik van Riel <riel@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, mgorman@suse.de,
chegu_vinod@hp.com
Subject: Re: [PATCH 2/4] sched,numa: weigh nearby nodes for task placement on complex NUMA topologies
Date: Fri, 09 May 2014 11:03:58 -0400 [thread overview]
Message-ID: <536CEE5E.9010609@redhat.com> (raw)
In-Reply-To: <20140509101317.GU30445@twins.programming.kicks-ass.net>
On 05/09/2014 06:13 AM, Peter Zijlstra wrote:
> On Thu, May 08, 2014 at 01:23:29PM -0400, riel@redhat.com wrote:
>> This patch does nothing on machines with simple NUMA topologies.
>
> Was this:
>
>> + /*
>> + * No need to calculate a score if the system has a simple NUMA
>> + * topology, with no node distances between "local" and "far away".
>> + */
>> + if (max_distance == LOCAL_DISTANCE)
>> + return 0;
>
> Supposed to make that true?
>
> It doesn't. That test is a !numa test, not a fully connected test.
>
Look at patch 1/4. I only set max_distance to !LOCAL_DISTANCE
if the system has multiple different distances in the SLIT
table.
I guess that needs to be cleaned up :)
next prev parent reply other threads:[~2014-05-09 15:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 17:23 [PATCH 0/4] sched,numa: task placement for complex NUMA topologies riel
2014-05-08 17:23 ` [PATCH 1/4] numa,x86: store maximum numa node distance riel
2014-05-09 9:45 ` Peter Zijlstra
2014-05-09 15:08 ` Rik van Riel
2014-05-08 17:23 ` [PATCH 2/4] sched,numa: weigh nearby nodes for task placement on complex NUMA topologies riel
2014-05-09 9:53 ` Peter Zijlstra
2014-05-09 15:14 ` Rik van Riel
2014-05-09 9:54 ` Peter Zijlstra
2014-05-09 10:03 ` Peter Zijlstra
2014-05-09 15:16 ` Rik van Riel
2014-05-09 10:11 ` Peter Zijlstra
2014-05-09 15:11 ` Rik van Riel
2014-05-09 10:13 ` Peter Zijlstra
2014-05-09 15:03 ` Rik van Riel [this message]
2014-05-08 17:23 ` [PATCH 3/4] sched,numa: store numa_group's preferred nid riel
2014-05-08 17:23 ` [PATCH 4/4] sched,numa: pull workloads towards their preferred nodes riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536CEE5E.9010609@redhat.com \
--to=riel@redhat.com \
--cc=chegu_vinod@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).