From: chenlifu <chenlifu@huawei.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
"npiggin@gmail.com" <npiggin@gmail.com>,
"nick.child@ibm.com" <nick.child@ibm.com>,
"zhengzucheng@huawei.com" <zhengzucheng@huawei.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"paulus@samba.org" <paulus@samba.org>,
"rppt@kernel.org" <rppt@kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"oohall@gmail.com" <oohall@gmail.com>
Subject: Re: [PATCH v2 -next] powerpc/powermac: Fix symbol not declared warnings
Date: Thu, 3 Nov 2022 15:08:14 +0800 [thread overview]
Message-ID: <536aa15f-5953-209f-488f-189f09a3c7b0@huawei.com> (raw)
In-Reply-To: <40a62a53-e971-ab26-6ec6-7727eb1d6a7e@csgroup.eu>
在 2022/11/2 21:53, Christophe Leroy 写道:
>
>
> Le 31/10/2022 à 01:45, chenlifu a écrit :
>> [Vous ne recevez pas souvent de courriers de chenlifu@huawei.com.
>> Découvrez pourquoi ceci est important à
>> https://aka.ms/LearnAboutSenderIdentification ]
>>
>> 在 2022/8/19 21:06, Chen Lifu 写道:
>>> 1. ppc_override_l2cr and ppc_override_l2cr_value are only used in
>>> l2cr_init() function, remove them and used *l2cr directly.
>>> 2. has_l2cache is not used outside of the file, so mark it static and
>>> do not initialise statics to 0.
>>>
>>> Fixes the following warning:
>>>
>>> arch/powerpc/platforms/powermac/setup.c:74:5: warning: symbol
>>> 'ppc_override_l2cr' was not declared. Should it be static?
>>> arch/powerpc/platforms/powermac/setup.c:75:5: warning: symbol
>>> 'ppc_override_l2cr_value' was not declared. Should it be static?
>>> arch/powerpc/platforms/powermac/setup.c:76:5: warning: symbol
>>> 'has_l2cache' was not declared. Should it be static?
>>>
>>> Signed-off-by: Chen Lifu <chenlifu@huawei.com>
>
> You could have replaced printk(KERN_INFO by pr_info(
Thanks, I have replaced printk(KERN_INFO by pr_info( in PATCH v3.
>
> Otherwise
>
> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>
>>> ---
>>> arch/powerpc/platforms/powermac/setup.c | 19 ++++++-------------
>>> 1 file changed, 6 insertions(+), 13 deletions(-)
>>>
>>> diff --git a/arch/powerpc/platforms/powermac/setup.c
>>> b/arch/powerpc/platforms/powermac/setup.c
>>> index 04daa7f0a03c..49faa066b372 100644
>>> --- a/arch/powerpc/platforms/powermac/setup.c
>>> +++ b/arch/powerpc/platforms/powermac/setup.c
>>> @@ -68,13 +68,11 @@
>>>
>>> #include "pmac.h"
>>>
>>> #undef SHOW_GATWICK_IRQS
>>>
>>> -int ppc_override_l2cr = 0;
>>> -int ppc_override_l2cr_value;
>>> -int has_l2cache = 0;
>>> +static int has_l2cache;
>>>
>>> int pmac_newworld;
>>>
>>> static int current_root_goodness = -1;
>>>
>>> @@ -234,26 +232,21 @@ static void __init l2cr_init(void)
>>>
>>> for_each_of_cpu_node(np) {
>>> const unsigned int *l2cr =
>>> of_get_property(np, "l2cr-value", NULL);
>>> if (l2cr) {
>>> - ppc_override_l2cr = 1;
>>> - ppc_override_l2cr_value = *l2cr;
>>> _set_L2CR(0);
>>> - _set_L2CR(ppc_override_l2cr_value);
>>> + _set_L2CR(*l2cr);
>>> + printk(KERN_INFO "L2CR overridden (0x%x), "
>>> + "backside cache is %s\n",
>>> + *l2cr, ((*l2cr) & 0x80000000) ?
>>> + "enabled" : "disabled");
>>> }
>>> of_node_put(np);
>>> break;
>>> }
>>> }
>>> -
>>> - if (ppc_override_l2cr)
>>> - printk(KERN_INFO "L2CR overridden (0x%x), "
>>> - "backside cache is %s\n",
>>> - ppc_override_l2cr_value,
>>> - (ppc_override_l2cr_value & 0x80000000)
>>> - ? "enabled" : "disabled");
>>> }
>>> #endif
>>>
>>> static void __init pmac_setup_arch(void)
>>> {
>>
>> Friendly ping ...
prev parent reply other threads:[~2022-11-03 7:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 13:06 [PATCH v2 -next] powerpc/powermac: Fix symbol not declared warnings Chen Lifu
2022-10-31 0:45 ` chenlifu
2022-11-02 13:53 ` Christophe Leroy
2022-11-03 7:08 ` chenlifu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536aa15f-5953-209f-488f-189f09a3c7b0@huawei.com \
--to=chenlifu@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nick.child@ibm.com \
--cc=npiggin@gmail.com \
--cc=oohall@gmail.com \
--cc=paulus@samba.org \
--cc=rppt@kernel.org \
--cc=zhengzucheng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).