From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758278AbaELNBb (ORCPT ); Mon, 12 May 2014 09:01:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16783 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758172AbaELNB3 (ORCPT ); Mon, 12 May 2014 09:01:29 -0400 Message-ID: <5370C620.9060303@redhat.com> Date: Mon, 12 May 2014 15:01:20 +0200 From: Tomas Henzl User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: ching CC: jbottomley@parallels.com, dan.carpenter@oracle.com, agordeev@redhat.com, linux-scsi@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1.1 2/16 update 3] arcmsr: Adding code to support MSI-X interrupt References: <1399463548.23184.6.camel@localhost> <536A43AF.6060908@redhat.com> <1399549025.25794.4.camel@localhost> <536CB8EB.3040401@redhat.com> <1399895733.4349.2.camel@localhost> In-Reply-To: <1399895733.4349.2.camel@localhost> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/12/2014 01:55 PM, ching wrote: > Hi Tomas, > > Thanks for your remind again. > The patch 17/17 will be as following. Hi Ching, I think we have messed up this thread a bit. Please repost the 2/16 with fixes related only to msi-x, this is the original 2/26 patch update with fixes directly related to it - free_irq + related fixes to error path. This should create a clear situation so James knows what he should take For the other changes - moving scsi_scan_host + flush_work etc. either create a 17/16 patch or wait until the 16/16 set is taken and then post a new patch. out_free_sysfs: -scsi_host_remove: - scsi_remove_host(host); -RAID_controller_stop: + del_timer_sync(&acb->eternal_timer); + flush_scheduled_work(); Btw, isn't flush_work(&acb->arcmsr_d.. better here? and if so the block looks almost identical to what is in arcmsr_shutdown, can we use it instead? Thanks, Tomas > arcmsr_stop_adapter_bgrb(acb); > arcmsr_flush_adapter_cache(acb); > + arcmsr_free_irq(pdev, acb); > +scsi_host_remove: > + scsi_remove_host(host); > +free_ccb_pool: > arcmsr_free_ccb_pool(acb); > free_hbb_mu: > arcmsr_free_mu(acb); > > > > On Fri, 2014-05-09 at 13:15 +0200, Tomas Henzl wrote: >> On 05/08/2014 01:37 PM, ching wrote: >>> Hi Tomas, >>> >>> Thanks for your suggestion. >>> I will add a new patch 17/17 at last. >> This additional patch was meant for moving the scsi_scan_host, because it's >> nor related to the ms-x interrupts. Probably the maintainer will prefer >> a single patch which changes msi-x at once, I don't care. >> To the patch below - you should also free the allocated irqs as I wrote previously. >> >> Cheers, >> Tomas >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html