From: Tomasz Figa <tomasz.figa@gmail.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
kgene.kim@samsung.com, t.figa@samsung.com
Cc: linux-kernel@vger.kernel.org, linux@arm.linux.org.uk,
ben-linux@fluff.org, arnd@arndb.de, olof@lixom.net,
marc.zyngier@arm.com, thomas.abraham@linaro.org,
kyungmin.park@samsung.com, inki.dae@samsung.com,
sw0312.kim@samsung.com, hyunhee.kim@samsung.com,
yj44.cho@samsung.com, chanho61.park@samsung.com,
sajjan.linux@gmail.com, tushar.behera@linaro.org,
sachin.kamat@linaro.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCHv5 2/5] ARM: EXYNOS: Support secondary CPU boot of Exynos3250
Date: Wed, 14 May 2014 21:32:33 +0200 [thread overview]
Message-ID: <5373C4D1.3070703@gmail.com> (raw)
In-Reply-To: <1399986308-23744-3-git-send-email-cw00.choi@samsung.com>
Hi,
On 13.05.2014 15:05, Chanwoo Choi wrote:
> This patch fix the offset of CPU boot address and don't need to send smc call
> of SMC_CMD_CPU1BOOT command for secondary CPU boot because Exynos3250 removes
> WFE in secure mode.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/mach-exynos/firmware.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c
> index 739bdc8..eb91d23 100644
> --- a/arch/arm/mach-exynos/firmware.c
> +++ b/arch/arm/mach-exynos/firmware.c
> @@ -30,6 +30,13 @@ static int exynos_do_idle(void)
> static int exynos_cpu_boot(int cpu)
> {
> /*
> + * Exynos3250 doesn't need to send smc command for secondary CPU boot
> + * because Exynos3250 removes WFE in secure mode.
> + */
> + if (soc_is_exynos3250())
> + return 0;
> +
> + /*
> * The second parameter of SMC_CMD_CPU1BOOT command means CPU id.
> * But, Exynos4212 has only one secondary CPU so second parameter
> * isn't used for informing secure firmware about CPU id.
> @@ -50,7 +57,7 @@ static int exynos_set_cpu_boot_addr(int cpu, unsigned long boot_addr)
>
> boot_reg = sysram_ns_base_addr + 0x1c;
>
> - if (!soc_is_exynos4212())
> + if (!soc_is_exynos4212() && !soc_is_exynos3250())
> boot_reg += 4*cpu;
>
> __raw_writel(boot_addr, boot_reg);
>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Best regards,
Tomasz
next prev parent reply other threads:[~2014-05-14 19:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 13:05 [PATCHv5 0/5] Support new Exynos3250 SoC based on Cortex-A7 dual core Chanwoo Choi
2014-05-13 13:05 ` [PATCHv5 1/5] ARM: EXYNOS: Add Exynos3250 SoC ID Chanwoo Choi
2014-05-13 13:05 ` [PATCHv5 2/5] ARM: EXYNOS: Support secondary CPU boot of Exynos3250 Chanwoo Choi
2014-05-14 19:32 ` Tomasz Figa [this message]
2014-05-13 13:05 ` [PATCHv5 3/5] clk: samsung: exynos3250: Add clocks using common clock framework Chanwoo Choi
2014-05-14 19:31 ` Tomasz Figa
2014-05-13 13:05 ` [PATCHv5 4/5] dt-bindings: add documentation for Exynos3250 clock controller Chanwoo Choi
2014-05-14 19:35 ` Tomasz Figa
2014-05-14 19:46 ` Kukjin Kim
2014-05-14 19:54 ` Tomasz Figa
2014-05-13 13:05 ` [PATCHv5 5/5] ARM: dts: Add device tree sources for Exynos3250 Chanwoo Choi
2014-05-14 19:36 ` Tomasz Figa
2014-05-15 4:28 ` [PATCHv5 0/5] Support new Exynos3250 SoC based on Cortex-A7 dual core Chanwoo Choi
2014-05-19 11:36 ` Tomasz Figa
2014-05-19 11:39 ` Tomasz Figa
2014-05-19 15:45 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5373C4D1.3070703@gmail.com \
--to=tomasz.figa@gmail.com \
--cc=arnd@arndb.de \
--cc=ben-linux@fluff.org \
--cc=chanho61.park@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=hyunhee.kim@samsung.com \
--cc=inki.dae@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=olof@lixom.net \
--cc=sachin.kamat@linaro.org \
--cc=sajjan.linux@gmail.com \
--cc=sw0312.kim@samsung.com \
--cc=t.figa@samsung.com \
--cc=thomas.abraham@linaro.org \
--cc=tushar.behera@linaro.org \
--cc=yj44.cho@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).