From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752315AbaENTf4 (ORCPT ); Wed, 14 May 2014 15:35:56 -0400 Received: from mail-ee0-f44.google.com ([74.125.83.44]:47863 "EHLO mail-ee0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751965AbaENTfx (ORCPT ); Wed, 14 May 2014 15:35:53 -0400 Message-ID: <5373C589.9080405@gmail.com> Date: Wed, 14 May 2014 21:35:37 +0200 From: Tomasz Figa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Chanwoo Choi , kgene.kim@samsung.com, t.figa@samsung.com CC: linux-kernel@vger.kernel.org, linux@arm.linux.org.uk, ben-linux@fluff.org, arnd@arndb.de, olof@lixom.net, marc.zyngier@arm.com, thomas.abraham@linaro.org, kyungmin.park@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, hyunhee.kim@samsung.com, yj44.cho@samsung.com, chanho61.park@samsung.com, sajjan.linux@gmail.com, tushar.behera@linaro.org, sachin.kamat@linaro.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Mike Turquette , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Randy Dunlap Subject: Re: [PATCHv5 4/5] dt-bindings: add documentation for Exynos3250 clock controller References: <1399986308-23744-1-git-send-email-cw00.choi@samsung.com> <1399986308-23744-5-git-send-email-cw00.choi@samsung.com> In-Reply-To: <1399986308-23744-5-git-send-email-cw00.choi@samsung.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 13.05.2014 15:05, Chanwoo Choi wrote: > The Exynos3250 clocks are statically listed and registered using the > Samsung specific common clock helper functions. Both device tree based > clock lookup and clkdev based clock lookups are supported. > > Signed-off-by: Chanwoo Choi > Signed-off-by: Tomasz Figa > Acked-by: Kyungmin Park > Cc: Mike Turquette > Cc: Kukjin Kim > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Cc: Ian Campbell > Cc: Kumar Gala > Cc: Randy Dunlap > Cc: Tomasz Figa > --- > .../devicetree/bindings/clock/exynos3250-clock.txt | 41 ++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/exynos3250-clock.txt > > diff --git a/Documentation/devicetree/bindings/clock/exynos3250-clock.txt b/Documentation/devicetree/bindings/clock/exynos3250-clock.txt > new file mode 100644 > index 0000000..aadc9c5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/exynos3250-clock.txt > @@ -0,0 +1,41 @@ > +* Samsung Exynos3250 Clock Controller > + > +The Exynos3250 clock controller generates and supplies clock to various > +controllers within the Exynos3250 SoC. > + > +Required Properties: > + > +- compatible: should be one of the following. > + - "samsung,exynos3250-cmu" - controller compatible with Exynos3250 SoC. > + > +- reg: physical base address of the controller and length of memory mapped > + region. > + > +- #clock-cells: should be 1. > + > +Each clock is assigned an identifier and client nodes can use this identifier > +to specify the clock which they consume. > + > +All available clocks are defined as preprocessor macros in > +dt-bindings/clock/exynos3250.h header and can be used in device > +tree sources. > + > +Example 1: An example of a clock controller node is listed below. > + > + cmu: clock-controller@10030000 { > + compatible = "samsung,exynos3250-cmu"; > + reg = <0x10030000 0x20000>; > + #clock-cells = <1>; > + }; > + > +Example 2: UART controller node that consumes the clock generated by the clock > + controller. Refer to the standard clock bindings for information > + about 'clocks' and 'clock-names' property. > + > + serial@13800000 { > + compatible = "samsung,exynos4210-uart"; > + reg = <0x13800000 0x100>; > + interrupts = <0 109 0>; > + clocks = <&cmu CLK_UART0>, <&cmu CLK_SCLK_UART0>; > + clock-names = "uart", "clk_uart_baud0"; > + }; > Oops, I've forgotten to apply this one. Since it doesn't have any dependencies, Kukjin, could you apply it on top of my pull requests with my Ack? Thanks in advance. Acked-by: Tomasz Figa Best regards, Tomasz