linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux-Arch <linux-arch@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-m68k <linux-m68k@vger.kernel.org>
Subject: Re: [PATCH 13/27] m68k: Use common bits from generic tlb.h
Date: Wed, 14 May 2014 22:57:50 +0200	[thread overview]
Message-ID: <5373D8CE.6090003@nod.at> (raw)
In-Reply-To: <CAMuHMdVWp8-aByVf+7M=8HEXXJRJBbZLdfj1v0rgDU-UEQM=8Q@mail.gmail.com>

Am 14.05.2014 21:34, schrieb Geert Uytterhoeven:
> Hi Richard,
> 
> On Wed, May 14, 2014 at 9:26 PM, Richard Weinberger <richard@nod.at> wrote:
>>> But why this sudden #ifdef checks?
>>
>> They are needed because in pgalloc.h you have:
>> #ifdef CONFIG_MMU
>> #include <asm/virtconvert.h>
>> #if defined(CONFIG_COLDFIRE)
>> #include <asm/mcf_pgalloc.h>
>> #elif defined(CONFIG_SUN3)
>> #include <asm/sun3_pgalloc.h>
>> #else
>> #include <asm/motorola_pgalloc.h>
>> #endif
>>
>> And only asm/motorola_pgalloc.h have __pte/pmd_free_tlb as static inline functions.
>> Therefore we need to define them such that the generic tlb.h versions will not clash
>> with yours.
> 
> Thanks for the clarification!

One problem which arises here is that me need to make sure that pgalloc.h is included before
tlb.h. Which kind of sucks.
I'll move __pte/pmd_free_tlb from *_pgalloc.h into tlb.h to prevent this issue.

Are you fine with that?

> Perhaps this deserves a comment:
> 
> /* Applies to Classic m68k MMU only */

Will add.

Thanks,
//richard

  reply	other threads:[~2014-05-14 20:57 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14 18:59 Consolidate tlb.h Richard Weinberger
2014-05-14 18:59 ` [PATCH 01/27] arm64: Override defaults from generic/tlb.h Richard Weinberger
2014-05-15  9:34   ` Catalin Marinas
2014-05-15  9:37     ` Richard Weinberger
2014-05-14 18:59 ` [PATCH 02/27] powerpc: " Richard Weinberger
2014-05-14 18:59 ` [PATCH 03/27] generic/tlb.h: Move common defines into generic tlb.h Richard Weinberger
2014-05-14 18:59 ` [PATCH 04/27] alpha: Use " Richard Weinberger
2014-05-14 19:05   ` Rik van Riel
2014-05-14 18:59 ` [PATCH 05/27] arc: Use common bits from " Richard Weinberger
2014-05-15  8:22   ` Vineet Gupta
2014-05-14 18:59 ` [PATCH 06/27] avr32: " Richard Weinberger
2014-05-14 18:59 ` [PATCH 07/27] blackfin: Use " Richard Weinberger
2014-05-14 18:59 ` [PATCH 08/27] c6x: " Richard Weinberger
2014-05-14 19:35   ` Mark Salter
2014-05-14 18:59 ` [PATCH 09/27] cris: Use common bits from " Richard Weinberger
2014-05-15  7:51   ` Jesper Nilsson
2014-05-14 18:59 ` [PATCH 10/27] frv: " Richard Weinberger
2014-05-14 18:59 ` [PATCH 11/27] hexagon: " Richard Weinberger
2014-05-20 23:58   ` rkuo
2014-05-14 18:59 ` [PATCH 12/27] m32r: Use " Richard Weinberger
2014-05-14 19:05   ` Rik van Riel
2014-05-14 18:59 ` [PATCH 13/27] m68k: Use common bits from " Richard Weinberger
2014-05-14 19:19   ` Geert Uytterhoeven
2014-05-14 19:26     ` Richard Weinberger
2014-05-14 19:34       ` Geert Uytterhoeven
2014-05-14 20:57         ` Richard Weinberger [this message]
2014-05-15  9:49           ` Geert Uytterhoeven
2014-05-14 18:59 ` [PATCH 14/27] metag: " Richard Weinberger
2014-05-15  8:59   ` James Hogan
2014-05-14 18:59 ` [PATCH 15/27] microblaze: Use " Richard Weinberger
2014-05-14 18:59 ` [PATCH 16/27] mips: Use common bits from " Richard Weinberger
2014-05-15 18:02   ` Leonid Yegoshin
2014-05-15 18:31     ` Richard Weinberger
2014-05-27  9:17   ` Ralf Baechle
2014-05-14 18:59 ` [PATCH 17/27] mn10300: Use " Richard Weinberger
2014-05-14 18:59 ` [PATCH 18/27] openrisc: " Richard Weinberger
2014-05-14 18:59 ` [PATCH 19/27] parisc: Use common bits from " Richard Weinberger
2014-05-14 18:59 ` [PATCH 20/27] powerpc: " Richard Weinberger
2014-05-14 18:59 ` [PATCH 21/27] score: Use " Richard Weinberger
2014-05-14 18:59 ` [PATCH 22/27] sh: Use common bits from " Richard Weinberger
2014-05-14 18:59 ` [PATCH 23/27] sparc: " Richard Weinberger
2014-05-14 19:55   ` Sam Ravnborg
2014-05-14 20:04     ` Richard Weinberger
2014-05-14 20:22       ` Sam Ravnborg
2014-05-14 20:27         ` Richard Weinberger
2014-05-15  3:13           ` Guenter Roeck
2014-05-14 18:59 ` [PATCH 24/27] tile: Use " Richard Weinberger
2014-05-14 18:59 ` [PATCH 25/27] unicore32: Use common bits from " Richard Weinberger
2014-05-21  9:27   ` 回复： " 管雪涛
2014-05-14 18:59 ` [PATCH 26/27] x86: " Richard Weinberger
2014-05-21 20:57   ` H. Peter Anvin
2014-05-14 18:59 ` [PATCH 27/27] xtensa: " Richard Weinberger
2014-05-15  8:32 ` Consolidate tlb.h Peter Zijlstra
2014-05-15  8:48   ` Richard Weinberger
2014-05-15  9:08     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5373D8CE.6090003@nod.at \
    --to=richard@nod.at \
    --cc=arnd@arndb.de \
    --cc=geert@linux-m68k.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).