From: Christopher Covington <cov@codeaurora.org>
To: Kumar Gala <galak@codeaurora.org>
Cc: Russell King <linux@arm.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [RFC] ARM: tty: Move HVC DCC assembly to arch/arm
Date: Thu, 22 May 2014 18:06:36 -0400 [thread overview]
Message-ID: <537E74EC.1020004@codeaurora.org> (raw)
In-Reply-To: <B273A106-344F-4D36-998B-E44F889AD93F@codeaurora.org>
Hi Kumar,
On 10/23/2013 01:59 AM, Kumar Gala wrote:
>
> On Oct 18, 2013, at 1:14 PM, Christopher Covington wrote:
>
>> Put architecture-specific assembly code where it belongs,
>> allowing for support of additional architectures such as arm64 in
>> the future.
>>
>> Signed-off-by: Christopher Covington <cov@codeaurora.org>
>> ---
>> arch/arm/include/asm/dcc.h | 45 +++++++++++++++++++++++++++++++++++++++++++
>> drivers/tty/hvc/hvc_dcc.c | 48 ++--------------------------------------------
>> 2 files changed, 47 insertions(+), 46 deletions(-)
>> create mode 100644 arch/arm/include/asm/dcc.h
>>
>> diff --git a/arch/arm/include/asm/dcc.h b/arch/arm/include/asm/dcc.h
>> new file mode 100644
>> index 0000000..306d1fc
>> --- /dev/null
>> +++ b/arch/arm/include/asm/dcc.h
>> @@ -0,0 +1,45 @@
>> +/* Copyright (c) 2010, The Linux Foundation. All rights reserved.
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 and
>> + * only version 2 as published by the Free Software Foundation.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + */
>> +
>> +#include <asm/barrier.h>
>> +
>> +/* DCC Status Bits */
>> +#define DCC_STATUS_RX (1 << 30)
>> +#define DCC_STATUS_TX (1 << 29)
>> +
>
> Why'd you move these define's here? They don't seem to be arch specific
> and I don't see them used in the asm anywhere.
Fixed in v2.
Christopher
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.
next prev parent reply other threads:[~2014-05-22 22:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 18:14 [RFC] ARM: tty: Move HVC DCC assembly to arch/arm Christopher Covington
2013-10-18 18:34 ` Stephen Boyd
2014-05-22 22:05 ` Christopher Covington
2014-05-22 22:18 ` Stephen Boyd
2013-10-23 5:59 ` Kumar Gala
2014-05-22 22:06 ` Christopher Covington [this message]
2014-05-22 22:07 ` [PATCH v2] " Christopher Covington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537E74EC.1020004@codeaurora.org \
--to=cov@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).