From: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>
To: Valdis.Kletnieks@vt.edu
Cc: Andrew Morton <akpm@linux-foundation.org>,
Kay Sievers <kay@vrfy.org>,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
Randy Dunlap <rdunlap@infradead.org>,
Petr Mladek <pmladek@suse.cz>,
Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
yrl.pp-manager.tt@hitachi.com,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Joe Perches <joe@perches.com>, Arun KS <arunks.linux@gmail.com>
Subject: Re: Re: [RFC PATCH 1/2] printk: Add context information to the header of /dev/kmsg
Date: Mon, 26 May 2014 16:18:01 +0900 [thread overview]
Message-ID: <5382EAA9.1010003@hitachi.com> (raw)
In-Reply-To: <11176.1400556970@turing-police.cc.vt.edu>
Hi,
(2014/05/20 12:36), Valdis.Kletnieks@vt.edu wrote:
> On Mon, 19 May 2014 19:28:38 +0900, Yoshihiro YUNOMAE said:
>
>> The header information is changed as follows:
>> <prefix>,<seq#>,<timestamp>,<fragmented>,<PID>/<interrupt context>;<msg>
>
> Has this been tested with popular userspace that reads /dev/kmsg, to make
> sure that it actually plays nice with a 5th field being added? Yes, I know
I checked it for systemd-journald and rsyslog on the source code level,
those tools don't handle new flag and field before ';' in the header of
/dev/kmsg. Those tools use only log level, sequence#, and timestamp.
So, even if we add these new flag and field for each message,
those tools will be able to work.
But, we'll fix this issue by other method if we found it in any
subsystems except for the SCSI layer.
(In the SCSI layer, we'll tackle this issue by using tracing feature.)
Thank you,
Yoshihiro YUNOMAE
--
Yoshihiro YUNOMAE
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: yoshihiro.yunomae.ez@hitachi.com
next prev parent reply other threads:[~2014-05-26 7:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 10:28 [RFC PATCH 0/2] printk: Add context information to kernel messages from /dev/kmsg Yoshihiro YUNOMAE
2014-05-19 10:28 ` [RFC PATCH 1/2] printk: Add context information to the header of /dev/kmsg Yoshihiro YUNOMAE
2014-05-19 11:35 ` Kay Sievers
2014-05-26 7:16 ` Yoshihiro YUNOMAE
2014-05-20 3:36 ` Valdis.Kletnieks
2014-05-26 7:18 ` Yoshihiro YUNOMAE [this message]
2014-05-19 10:28 ` [RFC PATCH 2/2] printk: Simplify fragmented line information of " Yoshihiro YUNOMAE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5382EAA9.1010003@hitachi.com \
--to=yoshihiro.yunomae.ez@hitachi.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=arunks.linux@gmail.com \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=joe@perches.com \
--cc=kay@vrfy.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=pmladek@suse.cz \
--cc=rdunlap@infradead.org \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).