From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tomer Maimon <tmaimon77@gmail.com>, Rob Herring <robh@kernel.org>
Cc: linus.walleij@linaro.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, avifishman70@gmail.com,
tali.perry1@gmail.com, joel@jms.id.au, venture@google.com,
yuenn@google.com, benjaminfair@google.com, j.neuschaefer@gmx.net,
openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v5 1/2] dt-binding: pinctrl: Add NPCM8XX pinctrl and GPIO documentation
Date: Sun, 27 Aug 2023 13:13:51 +0200 [thread overview]
Message-ID: <53987f0f-dfda-3572-1545-755072328be4@linaro.org> (raw)
In-Reply-To: <CAP6Zq1i+P8Jh2_G9gJMdtCKcVF6m9vkWAP5rJXBCJ1aNfc2Bvw@mail.gmail.com>
On 27/08/2023 11:44, Tomer Maimon wrote:
>>> + pinctrl: pinctrl@f0800260 {
>>> + compatible = "nuvoton,npcm845-pinctrl";
>>> + ranges = <0x0 0x0 0xf0010000 0x8000>;
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + nuvoton,sysgcr = <&gcr>;
>>> +
>>> + gpio0: gpio@f0010000 {
>>
>> unit-address should be 0.
>>
>> Otherwise,
> The unit-address is correct f0010000
Then how does it pass W=1 builds? How unit address can be f0010000 but
reg is 0? Really...
>>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>>
>>> + gpio-controller;
>>> + #gpio-cells = <2>;
>>> + reg = <0x0 0xB0>;
>
> Thanks,
>
> Tomer
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-27 11:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 18:57 [PATCH RESEND v5 0/2] pinctrl: nuvoton: add pinmux and GPIO driver for NPCM8XX Tomer Maimon
2023-08-09 18:57 ` [PATCH RESEND v5 1/2] dt-binding: pinctrl: Add NPCM8XX pinctrl and GPIO documentation Tomer Maimon
2023-08-21 17:09 ` Rob Herring
2023-08-27 9:44 ` Tomer Maimon
2023-08-27 11:13 ` Krzysztof Kozlowski [this message]
2023-08-27 15:30 ` Tomer Maimon
2023-08-27 18:04 ` Krzysztof Kozlowski
2023-08-09 18:57 ` [PATCH RESEND v5 2/2] pinctrl: nuvoton: add NPCM8XX pinctrl and GPIO driver Tomer Maimon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53987f0f-dfda-3572-1545-755072328be4@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j.neuschaefer@gmx.net \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).