From: Adrian Hunter <adrian.hunter@intel.com>
To: Wei Li <liwei391@huawei.com>,
acme@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org
Cc: peterz@infradead.org, mingo@redhat.com,
linux-kernel@vger.kernel.org, huawei.libin@huawei.com
Subject: Re: [PATCH] perf tools: intel-pt: fix endless record after being terminated
Date: Mon, 13 Jan 2020 16:47:18 +0200 [thread overview]
Message-ID: <539e4aca-3bae-6586-fefd-8be49308b5d7@intel.com> (raw)
In-Reply-To: <20200102074211.19901-1-liwei391@huawei.com>
On 2/01/20 9:42 am, Wei Li wrote:
> In __cmd_record(), when receiving SIGINT(ctrl + c), a done flag will
> be set and the event list will be disabled by evlist__disable() once.
>
> While in auxtrace_record.read_finish(), the related events will be
> enabled again, if they are continuous, the recording seems to be endless.
>
> If the intel_pt event is disabled, we don't enable it again here.
>
> Before the patch:
> huawei@huawei-2288H-V5:~/linux-5.5-rc4/tools/perf$ ./perf record -e \
> intel_pt//u -p 46803
> ^C^C^C^C^C^C
>
> After the patch:
> huawei@huawei-2288H-V5:~/linux-5.5-rc4/tools/perf$ ./perf record -e \
> intel_pt//u -p 48591
> ^C[ perf record: Woken up 0 times to write data ]
> Warning:
> AUX data lost 504 times out of 4816!
>
> [ perf record: Captured and wrote 2024.405 MB perf.data ]
>
> Signed-off-by: Wei Li <liwei391@huawei.com>
All ->read_finish() implementations seem the same, so can we make a common
helper auxtrace_read_finish() and set all .read_finish = to that.
> ---
> tools/perf/arch/x86/util/intel-pt.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/arch/x86/util/intel-pt.c b/tools/perf/arch/x86/util/intel-pt.c
> index 20df442fdf36..1e96afcd8646 100644
> --- a/tools/perf/arch/x86/util/intel-pt.c
> +++ b/tools/perf/arch/x86/util/intel-pt.c
> @@ -1173,9 +1173,13 @@ static int intel_pt_read_finish(struct auxtrace_record *itr, int idx)
> struct evsel *evsel;
>
> evlist__for_each_entry(ptr->evlist, evsel) {
> - if (evsel->core.attr.type == ptr->intel_pt_pmu->type)
> - return perf_evlist__enable_event_idx(ptr->evlist, evsel,
> - idx);
> + if (evsel->core.attr.type == ptr->intel_pt_pmu->type) {
> + if (evsel->disabled)
> + return 0;
> + else
> + return perf_evlist__enable_event_idx(
> + ptr->evlist, evsel, idx);
> + }
> }
> return -EINVAL;
> }
>
prev parent reply other threads:[~2020-01-13 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 7:42 [PATCH] perf tools: intel-pt: fix endless record after being terminated Wei Li
2020-01-06 12:02 ` Jiri Olsa
2020-01-14 13:45 ` Adrian Hunter
2020-01-13 14:47 ` Adrian Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539e4aca-3bae-6586-fefd-8be49308b5d7@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=huawei.libin@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).