From: "Yang,Wei" <Wei.Yang@windriver.com>
To: Michal Nazarewicz <mina86@mina86.com>,
Alan Stern <stern@rowland.harvard.edu>
Cc: <balbi@ti.com>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] USB:gadget: Fix a warning while loading g_mass_storage
Date: Thu, 19 Jun 2014 09:48:29 +0800 [thread overview]
Message-ID: <53A2416D.2090205@windriver.com> (raw)
In-Reply-To: <xa1t7g4ev3uv.fsf@mina86.com>
On 06/18/2014 07:44 PM, Michal Nazarewicz wrote:
> On Wed, Jun 18 2014, Yang,Wei wrote:
>> On 06/17/2014 10:18 PM, Alan Stern wrote:
>>> That is a strange question to ask. If you did not know that I approved
>>> the patch, why did you insert my Acked-By:?
>> I added your Acked-By, as when you reviewed V3, you mentioned that I
>> *may* add your Acked-by in this patch. If I misunderstood your point, I
>> am so sorry for that.
> Alan's point is that if you have any doubts whether someone approves
> your patch you should *not* add their Acked-by. So adding someone's
> Acked-by and then asking if they are fine with the patch is
> contradictory -- the former indicates that you believe the person is
> fine with the patch, while the latter shows that you aren't.
>
> Alan wrote:
>
>>>> With that change, you may add
>>>>
>>>> Acked-by: Alan Stern <stern@rowland.harvard.edu>
> so after adding “that change” you are in your right to add Alan's
> Acked-by, but what that also means is that Alan will be fine with the
> patch if you make the requested change, so you don't need to ask for an
> opinion again.
>
> PS. Note that “having any doubts” also means that if someone gave you
> their Acked-by, but then you substantially rewrite the patch, you
> probably should consider removing their Acked-by.
>
Michal, Thank you for your detailed explanation, it is very helpful to me.
Best Regards
Wei
next prev parent reply other threads:[~2014-06-19 1:49 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 9:37 [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage Wei.Yang
2014-06-03 14:48 ` Alan Stern
2014-06-04 1:20 ` Yang,Wei
2014-06-04 1:45 ` Peter Chen
2014-06-04 3:16 ` Yang,Wei
2014-06-04 4:41 ` Peter Chen
2014-06-04 13:56 ` Alan Stern
2014-06-04 18:48 ` Paul Zimmerman
2014-06-05 1:30 ` Peter Chen
2014-06-05 14:21 ` Alan Stern
2014-06-04 2:34 ` Yang,Wei
2014-06-04 12:06 ` Andrzej Pietrasiewicz
2014-06-04 15:26 ` Alan Stern
2014-06-05 10:00 ` Andrzej Pietrasiewicz
2014-06-05 18:10 ` Alan Stern
2014-06-04 4:32 ` [PATCH v2] " Wei.Yang
2014-06-05 18:08 ` Alan Stern
2014-06-09 6:02 ` Yang,Wei
2014-06-09 6:19 ` [PATCH v3] " Wei.Yang
2014-06-13 6:22 ` Yang,Wei
2014-06-13 13:39 ` Alan Stern
2014-06-14 13:10 ` Yang,Wei
2014-06-13 9:44 ` Michal Nazarewicz
2014-06-13 13:43 ` Alan Stern
2014-06-13 14:57 ` Michal Nazarewicz
2014-06-15 2:40 ` [PATCH] " Wei.Yang
2014-06-15 2:42 ` Yang,Wei
2014-06-17 5:59 ` Yang,Wei
2014-06-17 14:18 ` Alan Stern
2014-06-18 1:08 ` Yang,Wei
2014-06-18 11:44 ` Michal Nazarewicz
2014-06-18 14:22 ` Alan Stern
2014-06-19 1:48 ` Yang,Wei [this message]
2014-06-17 18:20 ` Michal Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A2416D.2090205@windriver.com \
--to=wei.yang@windriver.com \
--cc=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).