From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753338AbaFXTUI (ORCPT ); Tue, 24 Jun 2014 15:20:08 -0400 Received: from mail-lb0-f175.google.com ([209.85.217.175]:40515 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752599AbaFXTUE (ORCPT ); Tue, 24 Jun 2014 15:20:04 -0400 Message-ID: <53A9CF5F.6040806@bjorling.me> Date: Tue, 24 Jun 2014 21:19:59 +0200 From: Matias Bjorling User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Keith Busch CC: willy@linux.intel.com, sbradshaw@micron.com, axboe@fb.com, tom.leiming@gmail.com, hch@infradead.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH v8] NVMe: convert to blk-mq References: <1402661396-19207-1-git-send-email-m@bjorling.me> <1402661396-19207-2-git-send-email-m@bjorling.me> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 16-06-2014 17:57, Keith Busch skrev: > On Fri, 13 Jun 2014, Matias Bjørling wrote: >> This converts the current NVMe driver to utilize the blk-mq layer. > >> static void nvme_reset_notify(struct pci_dev *pdev, bool prepare) >> { >> - struct nvme_dev *dev = pci_get_drvdata(pdev); >> + struct nvme_dev *dev = pci_get_drvdata(pdev); >> >> - if (prepare) >> - nvme_dev_shutdown(dev); >> - else >> - nvme_dev_resume(dev); >> + spin_lock(&dev_list_lock); >> + if (prepare) >> + list_del_init(&dev->node); >> + else >> + list_add(&dev->node, &dev_list); >> + spin_unlock(&dev_list_lock); >> } >> + if (nvme_create_queue(dev->queues[i], i)) >> break; >> } > > The above change was just error injection test code so you can cause > a device to become unresponsive and trigger the timeout handling. > > This latest is otherwise stable on my dev machine. May I add an Acked-by from you?