From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756489AbaFYLnZ (ORCPT ); Wed, 25 Jun 2014 07:43:25 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37326 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752942AbaFYLnX (ORCPT ); Wed, 25 Jun 2014 07:43:23 -0400 Message-ID: <53AAB5D6.50500@suse.de> Date: Wed, 25 Jun 2014 13:43:18 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Organization: SUSE LINUX Products GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Mark Rutland , Doug Anderson CC: linux-samsung-soc , Stephan van Schaik , Vincent Palatin , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Randy Dunlap , Mark Brown , Simon Glass , Michael Spang , "OPEN FIRMWARE AND..." , DOCUMENTATION , LKML Subject: Re: [PATCH 3/4] Documentation: devicetree: Fix tps65090 typos References: <1403486483-4063-1-git-send-email-afaerber@suse.de> <1403486483-4063-4-git-send-email-afaerber@suse.de> <20140625104732.GE14495@leverpostej> In-Reply-To: <20140625104732.GE14495@leverpostej> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 25.06.2014 12:47, schrieb Mark Rutland: > On Mon, Jun 23, 2014 at 06:27:04PM +0100, Doug Anderson wrote: >> Andreas, >> >> On Sun, Jun 22, 2014 at 6:21 PM, Andreas Färber wrote: >>> It's vsys-l{1,2}-supply, not vsys_l{1,2}-supply. >>> >>> Signed-off-by: Andreas Färber >>> --- >>> Documentation/devicetree/bindings/regulator/tps65090.txt | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/regulator/tps65090.txt b/Documentation/devicetree/bindings/regulator/tps65090.txt >>> index 34098023..ca69f5e 100644 >>> --- a/Documentation/devicetree/bindings/regulator/tps65090.txt >>> +++ b/Documentation/devicetree/bindings/regulator/tps65090.txt >>> @@ -45,8 +45,8 @@ Example: >>> infet5-supply = <&some_reg>; >>> infet6-supply = <&some_reg>; >>> infet7-supply = <&some_reg>; >>> - vsys_l1-supply = <&some_reg>; >>> - vsys_l2-supply = <&some_reg>; >>> + vsys-l1-supply = <&some_reg>; >>> + vsys-l2-supply = <&some_reg>; >> >> Your change matches the code and all existing device trees in the >> Linux kernel. > > Could this fact please be mentioned in the commit message? Yes, I admit the commit message could've been clearer in stating that only the example is modified, not the actual specification. What about: "Specification and existing device trees use vsys-l{1,2}-supply, not vsys_l{1,2}-supply. Fix the example to match the specification." Maybe also "... typos in example" in the subject. Let me know whether I should send a v2 or let maintainers fix it up. Regards, Andreas > Given that: > > Acked-by: Mark Rutland > >> I also see plenty of other bindings with dashes, so this seems >> reasonable. > > Dashes rather than underscores are preferred/correct for property names > and compatible strings. Given no-one can possibly be using the > bad/incorrect form with underscores, fixing the documentation to use > dashes makes sense. > > Thanks, > Mark. -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg