From: Michal Marek <mmarek@suse.cz>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "H. Peter Anvin" <hpa@zytor.com>, X86 ML <x86@kernel.org>,
"linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kbuild: Do not run modules_install and install in paralel
Date: Mon, 07 Jul 2014 13:03:39 +0200 [thread overview]
Message-ID: <53BA7E8B.6090603@suse.cz> (raw)
In-Reply-To: <CALCETrWRo9B=q04dqGZZS0ojXaRxdA4kQ6UQWSaeq-Z6yD=7oQ@mail.gmail.com>
On 2014-07-05 01:45, Andy Lutomirski wrote:
> On Fri, Jul 4, 2014 at 3:15 PM, Michal Marek <mmarek@suse.cz> wrote:
>> Dne 13.6.2014 19:29, Andy Lutomirski napsal(a):
>>> On Fri, Jun 13, 2014 at 2:45 AM, Michal Marek <mmarek@suse.cz> wrote:
>>>> Dne 13.6.2014 11:39, Michal Marek napsal(a):
>>>>> Based on a x86-only patch by Andy Lutomirski <luto@amacapital.net>
>>>>>
>>>>> With modular kernels, 'make install' is going to need the installed
>>>>> modules at some point to generate the initramfs.
>>>>>
>>>>> Signed-off-by: Michal Marek <mmarek@suse.cz>
>>>>> ---
>>>>> Makefile | 6 ++++++
>>>>> 1 file changed, 6 insertions(+)
>>>>>
>>>>> diff --git a/Makefile b/Makefile
>>>>> index 7680d7c..7e5e483 100644
>>>>> --- a/Makefile
>>>>> +++ b/Makefile
>>>>> @@ -503,6 +503,12 @@ ifeq ($(KBUILD_EXTMOD),)
>>>>> endif
>>>>> endif
>>>>> endif
>>>>> +# install and module_install need also be processed one by one
>>>>> +ifneq ($(filter install,$(MAKECMDGOALS)),)
>>>>> + ifneq ($(filter modules_install,$(MAKECMDGOALS)),)
>>>>> + mixed-targets := 1
>>>>> + endif
>>>>> +endif
>>>>
>>>> Note that this version does not enforce the ordering, it just avoids the
>>>> interleaved execution. It can be added if desired.
>>>
>>> Hmm. This will fix 'make modules_install install' but will not fix
>>> 'make install modules_install'. I don't know how many people would
>>> type the latter.
>>
>> Resuming a thread from last month -- As I said, it does not enforce the
>> ordering. So it's not as bullet-proof as your patch, but it works on all
>> architectures. I'm thinking about adding the patch to kbuild.git for
>> 3.17. But if you want to fix the ordering as well, feel free to change
>> the __build_one_by_one rule to do this.
>
> Sounds good to me.
>
> Where's __build_one_by_one?
A few lines below in the main Makefile:
513 ifeq ($(mixed-targets),1)
514 #
======================================================================
=====
515 # We're called with mixed targets (*config and build targets).
516 # Handle them one by one.
517
518 PHONY += $(MAKECMDGOALS) __build_one_by_one
519
520 $(filter-out __build_one_by_one, $(MAKECMDGOALS)):
__build_one_by_one
521 @:
522
523 __build_one_by_one:
524 $(Q)set -e; \
525 for i in $(MAKECMDGOALS); do \
526 $(MAKE) -f $(srctree)/Makefile $$i; \
527 done
Michal
next prev parent reply other threads:[~2014-07-07 11:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 19:41 [PATCH] x86,build: Fix make -jN modules_install install Andy Lutomirski
2014-06-11 19:44 ` Sam Ravnborg
2014-06-11 19:46 ` Andy Lutomirski
2014-06-12 8:33 ` Michal Marek
2014-06-13 1:28 ` Andy Lutomirski
2014-06-13 9:39 ` [PATCH] kbuild: Do not run modules_install and install in paralel Michal Marek
2014-06-13 9:45 ` Michal Marek
2014-06-13 17:29 ` Andy Lutomirski
2014-07-04 22:15 ` Michal Marek
2014-07-04 23:45 ` Andy Lutomirski
2014-07-07 11:03 ` Michal Marek [this message]
2015-12-09 21:34 ` Andy Lutomirski
2015-12-10 14:45 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BA7E8B.6090603@suse.cz \
--to=mmarek@suse.cz \
--cc=hpa@zytor.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).