From: Alex Elder <elder@linaro.org>
To: heikki.krogerus@linux.intel.com
Cc: Greg KH <gregkh@linuxfoundation.org>,
david.daney@cavium.com, loic.poulain@intel.com,
linux-serial@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Subject: dw8250_set_termios() questions
Date: Fri, 11 Jul 2014 07:57:06 -0500 [thread overview]
Message-ID: <53BFDF22.1020302@linaro.org> (raw)
Heikki, I have not been a subscriber of the linux-serial
mailing list and didn't see this patch go by:
serial: 8250_dw: clock rate handling for all ACPI platforms
http://www.spinics.net/lists/linux-serial/msg12861.html
I had been working on doing something very similar for some
Broadcom device tree based devices and it might have been
helpful for me to have seen it. What I ended up with was
*very* similar to what you did. Here is the last version
of the patch I posted:
https://lkml.org/lkml/2014/7/1/323
There *are* some differences, and I'd like to inquire about
them before I simply use the code you have for my purpose.
These first two relate to whether I can use your
code as-is:
- Why do you skip setting the clock if a null "old"
pointer is supplied?
- I don't believe it's necessary to surround the clock
rate change with clk_disable_unprepare() and
clk_prepare_enable(). Do you believe otherwise?
This one is addressed to how your code is used now:
- Alan Cox had this question about my patch, and
it seems to apply to your code as well:
"This assumes an arbitarily configurable clock,
which is not I think the usual case."
https://lkml.org/lkml/2014/6/28/91
His point is that the clock, if adjustable, may
not support a rate that produces an acceptable
signal rate. Put another way, there may be a
better frequency than what the clock framework
selects that (in combination with the UART
divisor latch registers) produces the best--or
even a good--signal. Is there any chance any
ACPI platforms will suffer this problem?
Thanks.
-Alex
next reply other threads:[~2014-07-11 12:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 12:57 Alex Elder [this message]
2014-07-23 13:34 ` dw8250_set_termios() questions Alex Elder
2014-08-05 8:40 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BFDF22.1020302@linaro.org \
--to=elder@linaro.org \
--cc=david.daney@cavium.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=loic.poulain@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).