Re: [PATCH v3 05/12] phy: add the Berlin USB PHY driver

From: Varka Bhadram <varkabhadram@gmail.com>
To: "Antoine Ténart" <antoine.tenart@free-electrons.com>
Cc: sebastian.hesselbarth@gmail.com, Peter.Chen@freescale.com,
	balbi@ti.com, p.zabel@pengutronix.de,
	alexandre.belloni@free-electrons.com,
	thomas.petazzoni@free-electrons.com, zmxu@marvell.com,
	jszhang@marvell.com, linux-arm-kernel@lists.infradead.org,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 05/12] phy: add the Berlin USB PHY driver
Date: Wed, 16 Jul 2014 15:03:14 +0530	[thread overview]
Message-ID: <53C646DA.3020002@gmail.com> (raw)
In-Reply-To: <20140716092541.GC28151@kwain>

On 07/16/2014 02:55 PM, Antoine Ténart wrote:
> Hi Varka,
>
> On Wed, Jul 16, 2014 at 02:49:05PM +0530, Varka Bhadram wrote:
>> On 07/16/2014 01:55 PM, Antoine Ténart wrote:
>>> +static const struct of_device_id phy_berlin_sata_of_match[] = {
>>> +	{
>>> +		.compatible = "marvell,berlin2-usb-phy",
>>> +		.data = &phy_berlin_pll_dividers[0],
>>> +	},
>>> +	{
>>> +		.compatible = "marvell,berlin2cd-usb-phy",
>>> +		.data = &phy_berlin_pll_dividers[1],
>>> +	},
>>> +	{ },
>>> +};
>>> +MODULE_DEVICE_TABLE(of, phy_berlin_sata_of_match);
>>> +
>> It looks good if we move this after probe().. So that we can see of_match_table directly...
> We use the of match table in the probe, when calling of_match_device().
>
>>> +static int phy_berlin_usb_probe(struct platform_device *pdev)
>>> +{
>>> +	const struct of_device_id *match =
>>> +		of_match_device(phy_berlin_sata_of_match, &pdev->dev);

We are updating of_match_table in platform_driver struct.

Every driver follows the concept of giving the of_device_ids
above the platform_driver declaration...

> Here.
>
> Antoine
>