From: Mikko Perttunen <mperttunen@nvidia.com>
To: Varka Bhadram <varkabhadram@gmail.com>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"tj@kernel.org" <tj@kernel.org>,
"hdegoede@redhat.com" <hdegoede@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH v3 1/8] of: Add NVIDIA Tegra SATA controller binding
Date: Wed, 16 Jul 2014 14:42:50 +0300 [thread overview]
Message-ID: <53C6653A.7040107@nvidia.com> (raw)
In-Reply-To: <53C64553.9010704@gmail.com>
Thanks for you comment. I decided to keep the format as is for now,
however, to keep a consistent style between all binding files describing
Tegra hardware.
Mikko
On 16/07/14 12:26, Varka Bhadram wrote:
> On 07/16/2014 02:24 PM, Mikko Perttunen wrote:
>> This patch adds device tree binding documentation for the SATA
>> controller found on NVIDIA Tegra SoCs.
>>
>> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
>> ---
>> .../devicetree/bindings/ata/tegra-sata.txt | 30 ++++++++++++++++++++++
>> 1 file changed, 30 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/ata/tegra-sata.txt
>>
>> diff --git a/Documentation/devicetree/bindings/ata/tegra-sata.txt b/Documentation/devicetree/bindings/ata/tegra-sata.txt
>> new file mode 100644
>> index 0000000..946f207
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/ata/tegra-sata.txt
>> @@ -0,0 +1,30 @@
>> +Tegra124 SoC SATA AHCI controller
>> +
>> +Required properties :
>> +- compatible : "nvidia,tegra124-ahci".
>> +- reg : Should contain 2 entries:
>> + - AHCI register set (SATA BAR5)
>> + - SATA register set
>> +- interrupts : Defines the interrupt used by SATA
>> +- clocks : Must contain an entry for each entry in clock-names.
>> + See ../clocks/clock-bindings.txt for details.
>> +- clock-names : Must include the following entries:
>> + - sata
>> + - sata-oob
>> + - cml1
>> + - pll_e
>
> It would be more readable if it like this...
>
> Required properties :
> - compatible : "nvidia,tegra124-ahci".
> - reg : Should contain 2 entries:
> - AHCI register set (SATA BAR5)
> - SATA register set
> - interrupts : Defines the interrupt used by SATA
> - clocks : Must contain an entry for each entry in clock-names.
> See ../clocks/clock-bindings.txt for details.
> ....
>
>> +- resets : Must contain an entry for each entry in reset-names.
>> + See ../reset/reset.txt for details.
>> +- reset-names : Must include the following entries:
>> + - sata
>> + - sata-oob
>> + - sata-cold
>> +- phys : Must contain an entry for each entry in phy-names.
>> + See ../phy/phy-bindings.txt for details.
>> +- phy-names : Must include the following entries:
>> + - sata-phy : XUSB PADCTL SATA PHY
>> +- hvdd-supply : Defines the SATA HVDD regulator
>> +- vddio-supply : Defines the SATA VDDIO regulator
>> +- avdd-supply : Defines the SATA AVDD regulator
>> +- target-5v-supply : Defines the SATA 5V power regulator
>> +- target-12v-supply : Defines the SATA 12V power regulator
>
> Same....
>
>
next prev parent reply other threads:[~2014-07-16 11:42 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 8:54 [PATCH v3 0/8] Serial ATA support for NVIDIA Tegra124 Mikko Perttunen
2014-07-16 8:54 ` [PATCH v3 1/8] of: Add NVIDIA Tegra SATA controller binding Mikko Perttunen
2014-07-16 9:26 ` Varka Bhadram
2014-07-16 11:42 ` Mikko Perttunen [this message]
2014-07-16 11:40 ` [PATCH v4 " Mikko Perttunen
2014-07-16 11:49 ` Hans de Goede
2014-07-16 13:13 ` Thierry Reding
2014-07-16 14:47 ` Hans de Goede
2014-07-16 19:51 ` Thierry Reding
2014-07-17 6:51 ` Hans de Goede
2014-07-17 7:39 ` Thierry Reding
2014-07-17 7:56 ` Mikko Perttunen
2014-07-17 10:23 ` Hans de Goede
2014-07-17 10:52 ` Thierry Reding
2014-07-17 11:42 ` Hans de Goede
2014-07-17 11:48 ` Hans de Goede
2014-07-17 11:35 ` Mikko Perttunen
2014-07-18 7:11 ` [PATCH v5 " Mikko Perttunen
2014-07-18 7:16 ` Mikko Perttunen
2014-07-18 10:28 ` Hans de Goede
2014-07-18 11:32 ` Mikko Perttunen
2014-07-18 15:06 ` Thierry Reding
2014-07-18 21:54 ` Tejun Heo
2014-07-22 21:03 ` Stephen Warren
2014-07-18 10:26 ` Hans de Goede
2014-07-16 8:54 ` [PATCH v3 2/8] ARM: tegra: Add SATA controller to Tegra124 device tree Mikko Perttunen
2014-08-25 17:23 ` Stephen Warren
2014-08-26 7:14 ` Mikko Perttunen
2014-07-16 8:54 ` [PATCH v3 3/8] ARM: tegra: Add SATA and SATA power to Jetson TK1 " Mikko Perttunen
2014-07-16 8:54 ` [PATCH v3 4/8] clk: tegra: Enable hardware control of SATA PLL Mikko Perttunen
2014-07-16 8:54 ` [PATCH v3 5/8] clk: tegra: Add SATA clocks to Tegra124 initialization table Mikko Perttunen
2014-07-16 8:54 ` [PATCH v3 6/8] ata: ahci_platform: Increase AHCI_MAX_CLKS to 4 Mikko Perttunen
2014-07-16 8:54 ` [PATCH v3 7/8] ata: Add support for the Tegra124 SATA controller Mikko Perttunen
2014-07-16 11:14 ` Hans de Goede
2014-07-16 11:42 ` Thierry Reding
2014-07-16 11:40 ` [PATCH v4 " Mikko Perttunen
2014-07-18 7:12 ` [PATCH v5 " Mikko Perttunen
2014-07-18 10:26 ` Hans de Goede
2014-07-18 10:49 ` Mikko Perttunen
2014-07-16 8:54 ` [PATCH v3 8/8] ARM: tegra: Add options for Tegra AHCI support to tegra_defconfig Mikko Perttunen
2014-08-26 17:46 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C6653A.7040107@nvidia.com \
--to=mperttunen@nvidia.com \
--cc=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=tj@kernel.org \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).