From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932235AbaGWHJa (ORCPT ); Wed, 23 Jul 2014 03:09:30 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:46143 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755693AbaGWHJ1 (ORCPT ); Wed, 23 Jul 2014 03:09:27 -0400 Message-ID: <53CF5F9E.4020404@linaro.org> Date: Wed, 23 Jul 2014 16:09:18 +0900 From: AKASHI Takahiro User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Kees Cook CC: Will Drewry , Catalin Marinas , Will Deacon , dsaxena@linaro.org, "linux-arm-kernel@lists.infradead.org" , linaro-kernel@lists.linaro.org, LKML Subject: Re: [PATCH v5 0/3] arm64: Add seccomp support References: <1406020499-5537-1-git-send-email-takahiro.akashi@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/23/2014 05:16 AM, Kees Cook wrote: > On Tue, Jul 22, 2014 at 2:14 AM, AKASHI Takahiro > wrote: >> (Please apply this patch after my audit patch in order to avoid some >> conflict on arm64/Kconfig.) >> >> This patch enables secure computing (system call filtering) on arm64. >> System calls can be allowed or denied by loaded bpf-style rules. >> Architecture specific part is to run secure_computing() on syscall entry >> and check the result. See [3/3] > > Thanks for working on this! > >> Prerequisites are: >> * "arm64: Add audit support" patch >> >> This code is tested on ARMv8 fast model using >> * libseccomp v2.1.1 with modifications for arm64 and verified by its "live" >> tests, 20, 21 and 24. >> * modified version of Kees' seccomp test for 'changing/skipping a syscall' >> behavior > > Would you be able to share this? I'd love to add it to the seccomp > regression suite for the arm64-specific parts. Yep, I forked your repo here: https://github.com/t-akashi/seccomp.git (See trace_arm64 branch) Thanks, -Takahiro AKASHI > Thanks! > > -Kees > >> >> Changes v4 -> v5: >> * rebased to v3.16-rc >> * add patch [1/3] to allow ptrace to change a system call >> (please note that this patch should be applied even without seccomp.) >> >> Changes v3 -> v4: >> * removed the following patch and moved it to "arm64: prerequisites for >> audit and ftrace" patchset since it is required for audit and ftrace in >> case of !COMPAT, too. >> "arm64: is_compat_task is defined both in asm/compat.h and linux/compat.h" >> >> Changes v2 -> v3: >> * removed unnecessary 'type cast' operations [2/3] >> * check for a return value (-1) of secure_computing() explicitly [2/3] >> * aligned with the patch, "arm64: split syscall_trace() into separate >> functions for enter/exit" [2/3] >> * changed default of CONFIG_SECCOMP to n [2/3] >> >> Changes v1 -> v2: >> * added generic seccomp.h for arm64 to utilize it [1,2/3] >> * changed syscall_trace() to return more meaningful value (-EPERM) >> on seccomp failure case [2/3] >> * aligned with the change in "arm64: make a single hook to syscall_trace() >> for all syscall features" v2 [2/3] >> * removed is_compat_task() definition from compat.h [3/3] >> >> AKASHI Takahiro (3): >> arm64: ptrace: reload a syscall number after ptrace operations >> asm-generic: Add generic seccomp.h for secure computing mode 1 >> arm64: Add seccomp support >> >> arch/arm64/Kconfig | 14 ++++++++++++++ >> arch/arm64/include/asm/seccomp.h | 25 +++++++++++++++++++++++++ >> arch/arm64/include/asm/unistd.h | 3 +++ >> arch/arm64/kernel/entry.S | 2 ++ >> arch/arm64/kernel/ptrace.c | 18 ++++++++++++++++++ >> include/asm-generic/seccomp.h | 28 ++++++++++++++++++++++++++++ >> 6 files changed, 90 insertions(+) >> create mode 100644 arch/arm64/include/asm/seccomp.h >> create mode 100644 include/asm-generic/seccomp.h >> >> -- >> 1.7.9.5 >> > > >