From: Guenter Roeck <linux@roeck-us.net>
To: Sasha Levin <sasha.levin@oracle.com>, geert@linux-m68k.org
Cc: rostedt@goodmis.org, gnomes@lxorguk.ukuu.org.uk,
xerofoify@gmail.com, linux-m68k@vger.kernel.org,
linux-kernel@vger.kernel.org, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH] m68k/q40: Revert "m68k/q40: Fix q40_irq_startup() to return -ENXIO on failures"
Date: Wed, 23 Jul 2014 07:06:40 -0700 [thread overview]
Message-ID: <53CFC170.9090505@roeck-us.net> (raw)
In-Reply-To: <1406119899-22659-1-git-send-email-sasha.levin@oracle.com>
On 07/23/2014 05:51 AM, Sasha Levin wrote:
> Revert since we're trying to return -ENXIO from a function returning
> unsigned int. Not only it causes compiler warnings it's also obviously
> incorrect.
>
> In general, watch for patches from Nick Krause since they are not even
> build tested.
>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
Guess I wasn't fast enough with my comments :-(
Acked-by: Guenter Roeck <linux@roeck-us.net>
> ---
> arch/m68k/q40/q40ints.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/m68k/q40/q40ints.c b/arch/m68k/q40/q40ints.c
> index 9dfa1ea..513f9bb 100644
> --- a/arch/m68k/q40/q40ints.c
> +++ b/arch/m68k/q40/q40ints.c
> @@ -49,7 +49,7 @@ static unsigned int q40_irq_startup(struct irq_data *data)
> case 1: case 2: case 8: case 9:
> case 11: case 12: case 13:
> printk("%s: ISA IRQ %d not implemented by HW\n", __func__, irq);
> - return -ENXIO;
> + /* FIXME return -ENXIO; */
> }
> return 0;
> }
>
next prev parent reply other threads:[~2014-07-23 14:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 12:51 [PATCH] m68k/q40: Revert "m68k/q40: Fix q40_irq_startup() to return -ENXIO on failures" Sasha Levin
2014-07-23 14:06 ` Guenter Roeck [this message]
2014-07-23 15:39 ` Nick Krause
2014-07-23 16:02 ` Davidlohr Bueso
2014-07-26 15:21 ` Geert Uytterhoeven
2014-07-26 15:33 ` Sasha Levin
2014-07-26 15:57 ` Geert Uytterhoeven
2014-07-26 16:58 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CFC170.9090505@roeck-us.net \
--to=linux@roeck-us.net \
--cc=geert@linux-m68k.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sasha.levin@oracle.com \
--cc=sashal@kernel.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).