From: Guenter Roeck <linux@roeck-us.net>
To: Nicholas Krause <xerofoify@gmail.com>, monstr@monstr.eu
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] microblaze: Add comment for defines
Date: Wed, 23 Jul 2014 07:09:53 -0700 [thread overview]
Message-ID: <53CFC231.8090701@roeck-us.net> (raw)
In-Reply-To: <1406089658-4671-1-git-send-email-xerofoify@gmail.com>
On 07/22/2014 09:27 PM, Nicholas Krause wrote:
> This adds a comment for and removes a fix me by labeling these
> defines as memory cache definitions.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> arch/microblaze/include/asm/pvr.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/microblaze/include/asm/pvr.h b/arch/microblaze/include/asm/pvr.h
> index 4bbdb4c..441f3a0 100644
> --- a/arch/microblaze/include/asm/pvr.h
> +++ b/arch/microblaze/include/asm/pvr.h
> @@ -186,7 +186,7 @@ struct pvr_s {
> #define PVR_DCACHE_USE_FSL(_pvr) (_pvr.pvr[5] & PVR5_DCACHE_USE_FSL_MASK)
> #define PVR_DCACHE_ALLOW_WR(_pvr) \
> (_pvr.pvr[5] & PVR5_DCACHE_ALLOW_WR_MASK)
> -/* FIXME two shifts on one line needs any comment */
> +/* memory caches */
"two shifts on one line needs any comment"
You are not providing the comment asked for. The FIXME requests a comment explaining
why the double shift is needed, not just a random comment like the one you provided
that doesn't explain anything.
Guenter
> #define PVR_DCACHE_LINE_LEN(_pvr) \
> (1 << ((_pvr.pvr[5] & PVR5_DCACHE_LINE_LEN_MASK) >> 21))
> #define PVR_DCACHE_BYTE_SIZE(_pvr) \
>
prev parent reply other threads:[~2014-07-23 14:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 4:27 [PATCH] microblaze: Add comment for defines Nicholas Krause
2014-07-23 14:09 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CFC231.8090701@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).