From: "Jan Beulich" <JBeulich@suse.com>
To: <weiyj_lk@163.com>, "David Vrabel" <david.vrabel@citrix.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>
Cc: <xen-devel@lists.xenproject.org>,
"Wei Yongjun" <yongjun_wei@trendmicro.com.cn>,
<linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen/pciback: Fix error return code in xen_pcibk_attach()
Date: Wed, 23 Jul 2014 14:01:17 +0100 [thread overview]
Message-ID: <53CFCE3D02000078000251C0@mail.emea.novell.com> (raw)
In-Reply-To: <1405835161-8546-1-git-send-email-weiyj_lk@163.com>
>>> On 20.07.14 at 07:46, <weiyj_lk@163.com> wrote:
> --- a/drivers/xen/xen-pciback/xenbus.c
> +++ b/drivers/xen/xen-pciback/xenbus.c
> @@ -174,6 +174,7 @@ static int xen_pcibk_attach(struct xen_pcibk_device *pdev)
> "version mismatch (%s/%s) with pcifront - "
> "halting " DRV_NAME,
> magic, XEN_PCI_MAGIC);
> + err = -EFAULT;
> goto out;
> }
>
While -EFAULT is kind of odd here, I realize this is because the same
also gets passed to xenbus_dev_fatal(); -EILSEQ, -ENODATA, or
-EPROTO (despite it normally being network specific) would seem
better to me.
In any event
Reviewed-by Jan Beulich <jbeulich@suse.com>
next prev parent reply other threads:[~2014-07-23 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-20 5:46 [PATCH] xen/pciback: Fix error return code in xen_pcibk_attach() weiyj_lk
2014-07-23 13:01 ` Jan Beulich [this message]
2014-07-31 18:09 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CFCE3D02000078000251C0@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyj_lk@163.com \
--cc=xen-devel@lists.xenproject.org \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).