From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932701AbaGWRXC (ORCPT ); Wed, 23 Jul 2014 13:23:02 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:37632 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932285AbaGWRW7 (ORCPT ); Wed, 23 Jul 2014 13:22:59 -0400 Message-ID: <53CFEF6E.2060905@wwwdotorg.org> Date: Wed, 23 Jul 2014 11:22:54 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Nick Dyer CC: Dmitry Torokhov , Yufeng Shen , Daniel Kurtz , Henrik Rydberg , Joonyoung Shim , Alan Bowens , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Meerwald , Benson Leung , Olof Johansson , Sekhar Nori Subject: Re: [PATCH 00/15] atmel_mxt_ts - device tree, bootloader, etc References: <1404399697-26484-1-git-send-email-nick.dyer@itdev.co.uk> <53CECAEC.8080905@wwwdotorg.org> <53CFD50C.4040509@itdev.co.uk> In-Reply-To: <53CFD50C.4040509@itdev.co.uk> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/23/2014 09:30 AM, Nick Dyer wrote: > On 22/07/14 21:34, Stephen Warren wrote: >> Unfortunately, I still can't get these to work on my system. >> >> Per your "Re: atmel_mxt_ts: defaulting irqflags to >> IRQF_TRIGGER_FALLING", I set up the IRQ type in the Tegra DT file, and >> then applied this series on top of next-20140721. The driver appears to >> initialize OK, but neither X nor evtest see any events from the device. >> The IRQ count in /proc/interrupts doesn't increase when I touch the >> touchpad, but does when I press it hard enough to trigger the physical >> button. > > You're using the T19/GPIO support, then? In which case, there appears to be > something wrong on the touch controller rather than the driver itself. I assume I'm using T19, since there's a physical click action on the touchpad along with the normal touch detection. >> A boot log with debug enabled follows. No additional kernel log >> messages are generated by touches or clicks. > > Perhaps I should add some debug to mxt_input_button() - currently it will > not debug the fact that a click is received, although I guess that you will > see it in getevent. > >> Do you have any idea what I should try? > > I am suspicious that it may be that the power sequencing isn't quite right, > which sometimes leads to parts of the chip not working properly (eg GPIO > buttons working, but no touch). > > The patch "use deep sleep when stopped" removes the reset on every resume > (which would otherwise kill resume performance). But that reset tends to > paper over a device which hasn't been powered up properly in the first place. > > Could you try issuing a manual reset and see if the touch starts working? I > would normally do this by compiling our obp-utils software from > https://github.com/atmel-maxtouch/obp-utils using ndk-build and doing > something like: > > mxt-app -d i2c-dev:1-004b --reset > > (you need CONFIG_I2C_DEBUG to make /dev/i2c-1 appear) That didn't make any difference. I also tried the tool interactively. the "Display raw (M)essages" option never displayed anything, and the couple of self-tests I tried just timed out. "Read (I)nfo block" did display some values that seemed like they might be correct rather than random data. Interestingly though, I did bisect the series and found "Input: atmel_mxt_ts - use deep sleep mode when stopped" causes the problem. If I apply the whole series and revert that one patch, the touchpad works for mouse movement, but interestingly not for taps or physical clicks. ... >>> [ 1.831998] atmel_mxt_ts 1-004b: Interrupt triggered but zero messages > > FWIW, this warning generally means you should be using the CHG line mode 1 > in T18 COMMSCONFIG. It's benign, though. I'm not sure how I would adjust this; all firmware/config/... was flashed into the touchpad device itself before I received the system, and I don't have any firmware files on my host system.